Issue 5485073: Fixes a bug in atLeastFreeVars which was using objects as maps and failing on __proto__ and friends.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5485073: Fixes a bug in atLeastFreeVars which was using objects as maps and failing on proto and friends. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by Jasvir

Modified:
14 years, 10 months ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Adds MarkM's StringMap implementation and uses it instead of an object to gather free vars in atLeastFreeVars @ 4682

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -3 lines)			Patch
M	build.xml	View		3 chunks	+3 lines, -0 lines	0 comments	Download
A	src/com/google/caja/ses/StringMap.js	View	1	1 chunk	+55 lines, -0 lines	0 comments	Download
M	src/com/google/caja/ses/atLeastFreeVarNames.js	View	1	3 chunks	+8 lines, -2 lines	0 comments	Download
M	src/com/google/caja/ses/startSES.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2

lgtm