Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(189)

Issue 5484074: faster es53 freeze (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by felix8a
Modified:
14 years, 10 months ago
Reviewers:
MarkM, metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This change reduces runtime of a minimal test gadget from 2800ms to 2100ms in Chrome Beta (16.0), from 2300ms to 1800ms in Firefox Aurora (10.0), from 2300ms to 2100ms in Firefox Beta (9.0), from 1700ms to 1200ms in Safari 5.1.2 Basically, a much of the cost of es53+domado startup is freeze, and much of the cost of freeze is iterating over object properties, which includes inherited properties which have to be ignored. This change tries to use a native Object.keys function to do a fast initial filtering of the properties.

Patch Set 1 #

Total comments: 1

Patch Set 2 : faster es53 freeze #

Patch Set 3 : faster es53 freeze #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M src/com/google/caja/es53.js View 1 2 2 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 8
felix8a
14 years, 10 months ago (2011-12-14 06:52:29 UTC) #1
MarkM
http://codereview.appspot.com/5484074/diff/1/src/com/google/caja/es53.js File src/com/google/caja/es53.js (right): http://codereview.appspot.com/5484074/diff/1/src/com/google/caja/es53.js#newcode226 src/com/google/caja/es53.js:226: // Due to IE<9 bugs, this isn't identical to ...
14 years, 10 months ago (2011-12-14 07:00:57 UTC) #2
felix8a
On Tue, Dec 13, 2011 at 23:00, <erights@gmail.com> wrote: > > http://codereview.appspot.com/**5484074/diff/1/src/com/google/** > caja/es53.js<http://codereview.appspot.com/5484074/diff/1/src/com/google/caja/es53.js> > ...
14 years, 10 months ago (2011-12-14 07:25:35 UTC) #3
felix8a
new snapshot, clarified the IE<9 comment.
14 years, 10 months ago (2011-12-14 17:51:09 UTC) #4
felix8a
new snapshot, a few more micro-optimizations for freeze
14 years, 10 months ago (2011-12-14 18:09:20 UTC) #5
felix8a
On 2011/12/14 18:09:20, felix8a wrote: > new snapshot, a few more micro-optimizations for freeze now ...
14 years, 10 months ago (2011-12-14 18:38:22 UTC) #6
metaweta
lgtm
14 years, 10 months ago (2011-12-14 18:52:29 UTC) #7
felix8a
14 years, 10 months ago (2011-12-14 23:07:02 UTC) #8
@r4683
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b