flask-tryton: Add filters for date and number formating

bug13

[ced, 2020-04-19 10:03:16]

https://codereview.appspot.com/547950046/diff/573720044/flask_tryton.py
File flask_tryton.py (right):

https://codereview.appspot.com/547950046/diff/573720044/flask_tryton.py#newco...
flask_tryton.py:88: app.jinja_env.filters['tryton_timedelta'] =
Report.format_timedelta
For me it could be managed like others to set a default language.
The hasattr can be used on method definition.

https://codereview.appspot.com/547950046/diff/573720044/flask_tryton.py#newco...
flask_tryton.py:99: language = Transaction().context.get('language')
I think we should add a comment on why not using Transaction.language

[pokoli, 2020-04-26 20:33:24]

Fix comments

[pokoli, 2020-04-26 20:34:09]

Readd changelog

[ced, 2020-04-30 07:23:16]

https://codereview.appspot.com/547950046/diff/566000043/flask_tryton.py
File flask_tryton.py (right):

https://codereview.appspot.com/547950046/diff/566000043/flask_tryton.py#newco...
flask_tryton.py:77: app.jinja_env.filters['tryton_timedelta'] =
self.format_timedelta
It seems jinja2 practice is to name filters without '_'.
But I'm wondering if the tryton_ prefix is really the best one.
I'm wondering if we should not use the same names as flask-babel.

https://codereview.appspot.com/547950046/diff/566000043/flask_tryton.py#newco...
flask_tryton.py:77: app.jinja_env.filters['tryton_timedelta'] =
self.format_timedelta
I think adding those filters should be configurable and not activate by default.

[pokoli, 2020-04-30 11:01:15]

Follow flask-babel names and desging

[ced, 2020-05-06 09:33:31]

https://codereview.appspot.com/547950046/diff/583820043/README
File README (right):

https://codereview.appspot.com/547950046/diff/583820043/README#newcode10
README:10: Setting the configure_jinja flag adds the following filters on jinja
templates:
Please quote `configure_jinja`.

https://codereview.appspot.com/547950046/diff/583820043/README#newcode12
README:12: filters use the same format as tryton reports.
This filters applies the same formatting as Tryton reports.

https://codereview.appspot.com/547950046/diff/583820043/README#newcode21
README:21: >>> tryton = Tryton(app, configure_jinja=False)
I would put it to True on the example to show how it is used.

[pokoli, 2020-05-06 17:00:07]

Update to tip and fix comments

[ced, 2020-05-07 08:18:06]

https://codereview.appspot.com/547950046/diff/566070043/README
File README (right):

https://codereview.appspot.com/547950046/diff/566070043/README#newcode11
README:11: templates: `numberformat`, `dateformat`, `currencyformat` and
trailing space.

[pokoli, 2020-05-07 12:47:02]

Remove trailing space

[ced, 2020-05-07 19:12:20]

LGTM