Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(72)

Issue 547950046: flask-tryton: Add filters for date and number formating

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 2 weeks ago by pokoli
Modified:
4 weeks, 1 day ago
Reviewers:
ced
Visibility:
Public.

Description

bug13

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comments #

Patch Set 3 : Readd changelog #

Total comments: 2

Patch Set 4 : Follow flask-babel names and desging #

Total comments: 3

Patch Set 5 : Update to tip and fix comments #

Total comments: 1

Patch Set 6 : Remove trailing space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -2 lines) Patch
M CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M README View 1 2 3 4 5 2 chunks +5 lines, -1 line 0 comments Download
M flask_tryton.py View 1 2 3 3 chunks +45 lines, -1 line 0 comments Download

Messages

Total messages: 11
pokoli
1 month, 2 weeks ago (2020-04-18 18:44:21 UTC) #1
ced
https://codereview.appspot.com/547950046/diff/573720044/flask_tryton.py File flask_tryton.py (right): https://codereview.appspot.com/547950046/diff/573720044/flask_tryton.py#newcode88 flask_tryton.py:88: app.jinja_env.filters['tryton_timedelta'] = Report.format_timedelta For me it could be managed ...
1 month, 2 weeks ago (2020-04-19 10:03:16 UTC) #2
pokoli
Fix comments
1 month, 1 week ago (2020-04-26 20:33:24 UTC) #3
pokoli
Readd changelog
1 month, 1 week ago (2020-04-26 20:34:09 UTC) #4
ced
https://codereview.appspot.com/547950046/diff/566000043/flask_tryton.py File flask_tryton.py (right): https://codereview.appspot.com/547950046/diff/566000043/flask_tryton.py#newcode77 flask_tryton.py:77: app.jinja_env.filters['tryton_timedelta'] = self.format_timedelta It seems jinja2 practice is to ...
1 month, 1 week ago (2020-04-30 07:23:16 UTC) #5
pokoli
Follow flask-babel names and desging
1 month, 1 week ago (2020-04-30 11:01:15 UTC) #6
ced
https://codereview.appspot.com/547950046/diff/583820043/README File README (right): https://codereview.appspot.com/547950046/diff/583820043/README#newcode10 README:10: Setting the configure_jinja flag adds the following filters on ...
1 month ago (2020-05-06 09:33:31 UTC) #7
pokoli
Update to tip and fix comments
1 month ago (2020-05-06 17:00:07 UTC) #8
ced
https://codereview.appspot.com/547950046/diff/566070043/README File README (right): https://codereview.appspot.com/547950046/diff/566070043/README#newcode11 README:11: templates: `numberformat`, `dateformat`, `currencyformat` and trailing space.
1 month ago (2020-05-07 08:18:06 UTC) #9
pokoli
Remove trailing space
1 month ago (2020-05-07 12:47:02 UTC) #10
ced
4 weeks, 1 day ago (2020-05-07 19:12:20 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b