Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(704)

Issue 547920045: define-markup-command-internal -> module-define-markup-command!

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 3 weeks ago by dak
Modified:
4 weeks ago
Reviewers:
hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

define-markup-command-internal -> module-define-markup-command! Tangible benefits of this approach are not all that clear, and it doesn't cover define-markup-list-command in the current form either, so it warrants more work before committing or even deciding to commit. Particularly so since for convenience it reverts a previous patch combining the internals of define-markup-command and define-markup-list-command, in order to illustrate the approach just on the former. However, it works and provides a basis for discussion. The principal idea is to provide a version of define-markup-command that is not specific to the current module and not a macro, in a similar vein to how module-define! complements define , and use this in the parser rather than the previous somewhat fuzzier define-markup-command-internal . Additional commits: Add Lily_lexer::current_scope () function Revert "Express define-markup-list-command-internal using define-markup-command-internal" This reverts commit 9f1683921621b612b94080d506ee317b058b29c8.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -22 lines) Patch
M lily/include/lily-imports.hh View 2 chunks +1 line, -1 line 0 comments Download
M lily/include/lily-lexer.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/lily-imports.cc View 2 chunks +1 line, -1 line 0 comments Download
M lily/lily-lexer.cc View 4 chunks +12 lines, -2 lines 0 comments Download
M lily/parser.yy View 1 chunk +2 lines, -2 lines 0 comments Download
M scm/markup-macros.scm View 2 chunks +23 lines, -16 lines 0 comments Download

Messages

Total messages: 2
hanwenn
I don't understand how this approach could ever help byte-compiling the markup scheme files. This ...
4 weeks ago (2020-05-08 17:12:41 UTC) #1
dak
4 weeks ago (2020-05-08 17:30:10 UTC) #2
On 2020/05/08 17:12:41, hanwenn wrote:
> I don't understand how this approach could ever help byte-compiling the markup
> scheme files. This still uses module-define! , so the guile2 compilation step
> will be oblivious to  markup functions.

It makes it easier to create specific different behavior for byte-compilation
using eval-when.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b