Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1428)

Issue 547610043: Fix and align musicxml and input language "deutsch" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 4 weeks ago by dak
Modified:
4 months, 3 weeks ago
Reviewers:
Be-3, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix and align musicxml and input language "deutsch" Has commits: In \language "deutsch" use b only to replace hes The quartertone names should all be derived from h instead of b since beh was being used inconsistently. Fix deutsch language of musicxml2py Use b only for hes and nothing else. Also use asas and asah instead of ases and aseh.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add convert-ly rule. Ugh. #

Total comments: 3

Patch Set 3 : Also fix english quarternote names in musicexp.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M python/convertrules.py View 1 1 chunk +7 lines, -0 lines 0 comments Download
M python/musicexp.py View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M scm/define-note-names.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12
lemzwerg
LGTM https://codereview.appspot.com/547610043/diff/567190043/scm/define-note-names.scm File scm/define-note-names.scm (right): https://codereview.appspot.com/547610043/diff/567190043/scm/define-note-names.scm#newcode302 scm/define-note-names.scm:302: (heh . ,(ly:make-pitch -1 6 SEMI-FLAT)) What about ...
4 months, 4 weeks ago (2020-02-09 22:08:11 UTC) #1
dak
On 2020/02/09 22:08:11, lemzwerg wrote: > LGTM > > https://codereview.appspot.com/547610043/diff/567190043/scm/define-note-names.scm > File scm/define-note-names.scm (right): > ...
4 months, 4 weeks ago (2020-02-09 22:22:01 UTC) #2
lemzwerg
> > What about providing an alias for the old name 'beh' > for backward ...
4 months, 4 weeks ago (2020-02-09 22:27:55 UTC) #3
dak
On 2020/02/09 22:27:55, lemzwerg wrote: > > > What about providing an alias for the ...
4 months, 4 weeks ago (2020-02-09 23:37:40 UTC) #4
dak
Add convert-ly rule. Ugh.
4 months, 4 weeks ago (2020-02-10 02:07:20 UTC) #5
Be-3
We still have issues with English THREE-Q-* pitches (never worked, though). Please see my comment ...
4 months, 3 weeks ago (2020-02-11 20:07:13 UTC) #6
Be-3
Proposed solution for English (I know that this issue is about German only, but as ...
4 months, 3 weeks ago (2020-02-11 20:39:14 UTC) #7
dak
Also fix english quarternote names in musicexp.py
4 months, 3 weeks ago (2020-02-11 20:50:59 UTC) #8
dak
https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py File python/musicexp.py (right): https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py#newcode324 python/musicexp.py:324: return str On 2020/02/11 20:39:14, Be-3 wrote: > Proposal: ...
4 months, 3 weeks ago (2020-02-11 20:54:19 UTC) #9
Be-3
On 2020/02/11 20:54:19, dak wrote: > https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py > File python/musicexp.py (right): > > https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py#newcode324 > ...
4 months, 3 weeks ago (2020-02-13 03:01:18 UTC) #10
Be-3
German and English successfully tested. proposal for espanol (missing quarter notes) and portuques (still completely ...
4 months, 3 weeks ago (2020-02-13 03:03:13 UTC) #11
dak
4 months, 3 weeks ago (2020-02-13 22:40:39 UTC) #12
Given by Torsten Hämmerle after issue 5746 completed
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b