Issue 54740043: Remove obsolete default tools url

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54740043: Remove obsolete default tools url (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by wallyworld

Modified:
10 years, 3 months ago

Reviewers:
mp+202391, axw

Visibility:
Public.

Description

Remove obsolete default tools url Synctools was defining it's own DefaultToolsLocation URL which sort of duplicated the default simplestreams default URL. But sync tools has been refactored to use simplestreams and so this duplication is unecessary. There were also a number of other small refactorings to clean up the tools code. https://code.launchpad.net/~wallyworld/juju-core/remove-obsolete-synctools-url/+merge/202391 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -44 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/bootstrap.go	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	cmd/juju/bootstrap_test.go	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	cmd/plugins/juju-metadata/toolsmetadata.go	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	cmd/plugins/juju-metadata/toolsmetadata_test.go	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	environs/bootstrap/bootstrap_test.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/bootstrap/synctools.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/sync/sync.go	View	3 chunks	+6 lines, -20 lines	0 comments	Download
M	environs/sync/sync_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/testing/tools.go	View	3 chunks	+3 lines, -8 lines	0 comments	Download
M	environs/tools/tools_test.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/tools/urls.go	View	2 chunks	+33 lines, -2 lines	0 comments	Download
M	environs/tools/urls_test.go	View	1 chunk	+13 lines, -0 lines	2 comments	Download
M	state/apiserver/client/client_test.go	View	4 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

axw

LGTM, but I would like to see an additional test https://codereview.appspot.com/54740043/diff/1/environs/tools/urls_test.go File environs/tools/urls_test.go (right): https://codereview.appspot.com/54740043/diff/1/environs/tools/urls_test.go#newcode95 ...

10 years, 3 months ago (2014-01-21 01:26:51 UTC) #2

wallyworld

10 years, 3 months ago (2014-01-21 02:37:32 UTC) #3

https://codereview.appspot.com/54740043/diff/1/environs/tools/urls_test.go
File environs/tools/urls_test.go (right):

https://codereview.appspot.com/54740043/diff/1/environs/tools/urls_test.go#ne...
environs/tools/urls_test.go:95: "foo":        "file://foo/tools",
On 2014/01/21 01:26:51, axw wrote:
> How about a test for a path with an absolute filesystem path?

Done.

Expand All Messages | Collapse All Messages