Quick start sample on provisioning org units

[gunjansharma, 2011-12-12 13:38:06]

http://codereview.appspot.com/5472058/diff/1/samples/apps/orgunit_quick_start...
File samples/apps/orgunit_quick_start_example.py (right):

http://codereview.appspot.com/5472058/diff/1/samples/apps/orgunit_quick_start...
samples/apps/orgunit_quick_start_example.py:24: $ python
userprovisioning_quick_start_example.py
orgunit

http://codereview.appspot.com/5472058/diff/1/samples/apps/orgunit_quick_start...
samples/apps/orgunit_quick_start_example.py:160: org_unit_path=org_unit_path)
Run glint.

http://codereview.appspot.com/5472058/diff/1/samples/apps/orgunit_quick_start...
samples/apps/orgunit_quick_start_example.py:186: def _RetrieveOrgUnit(self,
customer_id):
Args description missing in many functions.

http://codereview.appspot.com/5472058/diff/1/samples/apps/orgunit_quick_start...
samples/apps/orgunit_quick_start_example.py:216: if org_unit_path is None:
You can make a function that asks user for a org_unit_path since you have to do
the same thing every where.

[shraddhag, 2011-12-12 15:17:19]

Addressed comments in sample.

Changed apps client to use desired_class in place of constructing object

http://codereview.appspot.com/5472058/diff/1/samples/apps/orgunit_quick_start...
File samples/apps/orgunit_quick_start_example.py (right):

http://codereview.appspot.com/5472058/diff/1/samples/apps/orgunit_quick_start...
samples/apps/orgunit_quick_start_example.py:24: $ python
userprovisioning_quick_start_example.py
On 2011/12/12 13:38:06, gunjansharma wrote:
> orgunit

Done.

http://codereview.appspot.com/5472058/diff/1/samples/apps/orgunit_quick_start...
samples/apps/orgunit_quick_start_example.py:160: org_unit_path=org_unit_path)
On 2011/12/12 13:38:06, gunjansharma wrote:
> Run glint.

Done.

http://codereview.appspot.com/5472058/diff/1/samples/apps/orgunit_quick_start...
samples/apps/orgunit_quick_start_example.py:186: def _RetrieveOrgUnit(self,
customer_id):
On 2011/12/12 13:38:06, gunjansharma wrote:
> Args description missing in many functions.

Done.

http://codereview.appspot.com/5472058/diff/1/samples/apps/orgunit_quick_start...
samples/apps/orgunit_quick_start_example.py:216: if org_unit_path is None:
On 2011/12/12 13:38:06, gunjansharma wrote:
> You can make a function that asks user for a org_unit_path since you have to
do
> the same thing every where.

Done.

[gunjansharma, 2011-12-13 09:35:20]

http://codereview.appspot.com/5472058/diff/4001/samples/apps/orgunit_quick_st...
File samples/apps/orgunit_quick_start_example.py (right):

http://codereview.appspot.com/5472058/diff/4001/samples/apps/orgunit_quick_st...
samples/apps/orgunit_quick_start_example.py:127: """Gets org_unit_path from
user."""
@return stmt missing
In some functions.

http://codereview.appspot.com/5472058/diff/4001/samples/apps/orgunit_quick_st...
samples/apps/orgunit_quick_start_example.py:245: org_unit_path=org_unit_path)
start from column after ( in above line.
Refer glint.

http://codereview.appspot.com/5472058/diff/4001/samples/apps/orgunit_quick_st...
samples/apps/orgunit_quick_start_example.py:276: org_unit_path=org_unit_path,
users_to_move=users)
Here too. Either drop customer_id=customer_id in new line with 4 space
indentation or indent this line to come below customer_id=customer_id

http://codereview.appspot.com/5472058/diff/4001/src/gdata/apps/client.py
File src/gdata/apps/client.py (right):

http://codereview.appspot.com/5472058/diff/4001/src/gdata/apps/client.py#newc...
src/gdata/apps/client.py:72: next_feed = self.GetFeed(next.href,
desired_class=gdata.apps.data.UserFeed)
Line is long.

[shraddhag, 2011-12-13 09:46:14]

http://codereview.appspot.com/5472058/diff/4001/samples/apps/orgunit_quick_st...
File samples/apps/orgunit_quick_start_example.py (right):

http://codereview.appspot.com/5472058/diff/4001/samples/apps/orgunit_quick_st...
samples/apps/orgunit_quick_start_example.py:245: org_unit_path=org_unit_path)
This is not a requirement for our code. AFAIK, we dont follow all of lint
suggestions.
On 2011/12/13 09:35:20, gunjansharma wrote:
> start from column after ( in above line.
> Refer glint.

[gunjansharma, 2011-12-13 09:48:16]

There are few more  comments.

Thanks
Gunjan Sharma |  Developer Programs Engineer | gunjansharma@google.com |  +91
7702534446



On Tue, Dec 13, 2011 at 3:16 PM, <shraddhag@google.com> wrote:

>
> http://codereview.appspot.com/**5472058/diff/4001/samples/**
>
apps/orgunit_quick_start_**example.py<http://codereview.appspot.com/5472058/diff/4001/samples/apps/orgunit_quick_start_example.py>
> File samples/apps/orgunit_quick_**start_example.py (right):
>
> http://codereview.appspot.com/**5472058/diff/4001/samples/**
>
apps/orgunit_quick_start_**example.py#newcode245<http://codereview.appspot.com/5472058/diff/4001/samples/apps/orgunit_quick_start_example.py#newcode245>
> samples/apps/orgunit_quick_**start_example.py:245:
> org_unit_path=org_unit_path)
> This is not a requirement for our code. AFAIK, we dont follow all of
> lint suggestions.
>
> On 2011/12/13 09:35:20, gunjansharma wrote:
>
>> start from column after ( in above line.
>> Refer glint.
>>
>
>
http://codereview.appspot.com/**5472058/<http://codereview.appspot.com/5472058/>
>

[gunjansharma, 2011-12-13 10:17:05]

LGTM

[shraddhag, 2011-12-13 11:37:11]

Claudio, can I submit this code.
Take a look

Thanks,
Shraddha Gupta
Developer Programs Engineer
Hyderabad, Google India.



On Tue, Dec 13, 2011 at 3:47 PM, <gunjansharma@google.com> wrote:

> LGTM
>
>
http://codereview.appspot.com/**5472058/<http://codereview.appspot.com/5472058/>
>

[Claudio Cherubino, 2011-12-13 11:49:38]

Sure, Gunjan approved your code and that's enough for me.

Claudio

On Tue, Dec 13, 2011 at 12:37 PM, Shraddha Gupta <shraddhag@google.com>wrote:

> Claudio, can I submit this code.
> Take a look
>
> Thanks,
> Shraddha Gupta
> Developer Programs Engineer
> Hyderabad, Google India.
>
>
>
> On Tue, Dec 13, 2011 at 3:47 PM, <gunjansharma@google.com> wrote:
>
>> LGTM
>>
>>
http://codereview.appspot.com/**5472058/<http://codereview.appspot.com/5472058/>
>>
>
>