Issue 54690045: Add a couple of cert utility methods

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54690045: Add a couple of cert utility methods

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by ekasper

Modified:
10 years, 2 months ago

Reviewers:
Eran

CC:
ctlog-opensource-review_google.com

Visibility:
Public.

More Reviews

Description

Add a couple of cert utility methods

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
	M	src/python/ct/crypto/cert.py	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	src/python/ct/crypto/cert_test.py	View	1	2 chunks	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Eran

10 years, 3 months ago (2014-01-27 16:49:16 UTC) #2

LGTM, minor comment below.

https://codereview.appspot.com/54690045/diff/1/src/python/ct/crypto/cert_test.py
File src/python/ct/crypto/cert_test.py (right):

https://codereview.appspot.com/54690045/diff/1/src/python/ct/crypto/cert_test...
src/python/ct/crypto/cert_test.py:171: def test_identical(self):
Nit: It's now considered good practice to separate these groups of assertions to
separate unit tests

Expand All Messages | Collapse All Messages