Issue 54660046: code review 54660046: cmd/6a: include MOVQL opcode.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54660046: code review 54660046: cmd/6a: include MOVQL opcode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by khr

Modified:
11 years, 4 months ago

Reviewers:
r, rsc

CC:
golang-codereviews, r

Visibility:
Public.

Patch Set 2 : diff -r c10b1fb56393 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r c10b1fb56393 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 85e6a26d84ba https://khr%40golang.org@code.google.com/p/go/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/cmd/6a/lex.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

khr

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/

11 years, 5 months ago (2014-01-27 18:40:10 UTC) #1

khr

*** Submitted as https://code.google.com/p/go/source/detail?r=8eba3dcd8ee0 *** cmd/6a: include MOVQL opcode. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://codereview.appspot.com/54660046

11 years, 5 months ago (2014-01-27 19:17:14 UTC) #3

rsc

Why? MOVQL is a pseudo-opcode used only inside 6g, to distinguish a MOVL whose purpose ...

11 years, 4 months ago (2014-02-10 14:40:01 UTC) #4

rsc

11 years, 4 months ago (2014-02-10 16:16:48 UTC) #5

I see the discussion on the other thread. The code is fine, just a little
surprising.

Expand All Messages | Collapse All Messages