Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7241)

Issue 5464048: Two minor adjustments for Google Test on Android

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by Peter Beverloo
Modified:
8 months ago
Reviewers:
CC:
googletestframework_googlegroups.com
Base URL:
http://googletest.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Two minor adjustments for Google Test on Android The __linux__ define is set for Android builds when using Chromium code[1], but the same applies when the "ANDROID" define is available. Android uses /data/local/tmp for the temporary folder (at least on rooted devices) rather than /tmp. [1] http://codesearch.google.com/#OAMlx_jo-ck/src/build/common.gypi&exact_package=chromium&q=__linux__%20file:gyp&type=cs&l=2058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M include/gtest/internal/gtest-port.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gtest-port.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Peter Beverloo
Hi guys, it'd be great if you could take a look at this!
12 years, 2 months ago (2011-12-08 15:38:05 UTC) #1
Peter Beverloo
12 years, 2 months ago (2011-12-16 14:39:54 UTC) #2
On 2011/12/08 15:38:05, Peter Beverloo wrote:
> Hi guys, it'd be great if you could take a look at this!

Ping.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b