Issue 54590044: tasks.wait_for() does not cancel the task in case of timeout

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54590044: tasks.wait_for() does not cancel the task in case of timeout

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by gjcarneiro

Modified:
10 years, 3 months ago

Reviewers:
haypo_gmail

Visibility:
Public.

More Reviews

Description

tasks.wait_for() does not cancel the task in case of timeout

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -18 lines)			Patch
	M	asyncio/tasks.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download
	M	tests/test_tasks.py	View	1	2 chunks	+15 lines, -16 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

haypo_gmail

10 years, 3 months ago (2014-01-21 01:52:10 UTC) #1

https://codereview.appspot.com/54590044/diff/1/tests/test_tasks.py
File tests/test_tasks.py (right):

https://codereview.appspot.com/54590044/diff/1/tests/test_tasks.py#newcode378
tests/test_tasks.py:378: self.assertTrue(fut.done())
You should check that the future was cancelled, check for example the
cancelled() method?

https://codereview.appspot.com/54590044/diff/1/tests/test_tasks.py#newcode409
tests/test_tasks.py:409: self.assertTrue(fut.done())
Ditto

Expand All Messages | Collapse All Messages