Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 54560043: Support the new juju switch behavior.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by frankban
Modified:
10 years, 3 months ago
Reviewers:
mp+202299, gary.poster
Visibility:
Public.

Description

Support the new juju switch behavior. Quickstart is now able to retrieve the default environment name in newer versions of juju-core. Tests: `make check`. No QA required. https://code.launchpad.net/~frankban/juju-quickstart/new-juju-switch/+merge/202299 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Support the new juju switch behavior. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/models/envs.py View 1 chunk +7 lines, -4 lines 0 comments Download
M quickstart/tests/models/test_envs.py View 3 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
10 years, 3 months ago (2014-01-20 12:04:15 UTC) #1
gary.poster
LGTM. thank you! (not here today, but trying to help out :-)
10 years, 3 months ago (2014-01-20 12:25:47 UTC) #2
frankban
*** Submitted: Support the new juju switch behavior. Quickstart is now able to retrieve the ...
10 years, 3 months ago (2014-01-20 12:30:37 UTC) #3
frankban
10 years, 3 months ago (2014-01-20 12:40:55 UTC) #4
Thank you for reviewing this while on holiday Gary!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b