Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1369)

Issue 545280043: Issue 5620: Change vector<Grob *> to vector<Paper_column *> (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by Dan Eble
Modified:
4 years, 3 months ago
Reviewers:
lemzwerg, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5620/ Patch 1 contains some preparatory clean-up that is a bit more involved than just changing types and casts. Patch 2 is the simpler but more extensive work of changing the types and casts.

Patch Set 1 : reduce dynamic casting in searches #

Patch Set 2 : change pointer types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -105 lines) Patch
M lily/axis-group-interface.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lily/constrained-breaking.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M lily/include/column-x-positions.hh View 1 1 chunk +4 lines, -2 lines 0 comments Download
M lily/include/constrained-breaking.hh View 1 3 chunks +4 lines, -2 lines 0 comments Download
M lily/include/paper-column.hh View 1 2 chunks +6 lines, -2 lines 0 comments Download
M lily/include/paper-score.hh View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lily/include/simple-spacer.hh View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lily/include/spacing-spanner.hh View 1 1 chunk +5 lines, -5 lines 0 comments Download
M lily/include/system.hh View 1 2 chunks +4 lines, -4 lines 0 comments Download
M lily/one-line-auto-height-breaking.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/one-line-page-breaking.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/page-breaking.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M lily/paper-book.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M lily/paper-column.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M lily/paper-score.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lily/simple-spacer.cc View 1 7 chunks +34 lines, -26 lines 0 comments Download
M lily/spacing-determine-loose-columns.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M lily/spacing-spanner.cc View 1 7 chunks +12 lines, -12 lines 0 comments Download
M lily/system.cc View 1 7 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 5
Dan Eble
change types
4 years, 4 months ago (2019-11-25 22:49:20 UTC) #1
Dan Eble
4 years, 4 months ago (2019-11-25 22:56:10 UTC) #2
lemzwerg
LGTM. The goal is to have less dynamic casts, right?
4 years, 4 months ago (2019-11-26 08:25:04 UTC) #3
Dan Eble
On 2019/11/26 08:25:04, lemzwerg wrote: > LGTM. The goal is to have less dynamic casts, ...
4 years, 4 months ago (2019-11-26 15:16:08 UTC) #4
Carl
4 years, 4 months ago (2019-11-26 16:24:10 UTC) #5
I'm glad to see this.  It clears up some of the confusion I've had in digging
into the code relative to the distinctions between Item, Grob, and Paper_column.
 

Thanks,

Carl
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b