Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(153)

Issue 5452045: TCP options feature for ns-3

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by Adrian
Modified:
8 years, 2 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

initial upload

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+1307 lines, -3 lines) Patch
M src/internet/model/tcp-header.h View 3 chunks +11 lines, -0 lines 0 comments Download
M src/internet/model/tcp-header.cc View 4 chunks +75 lines, -2 lines 0 comments Download
M src/internet/model/tcp-l4-protocol.cc View 1 chunk +0 lines, -1 line 0 comments Download
A src/internet/model/tcp-option.h View 1 chunk +56 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option.cc View 1 chunk +91 lines, -0 lines 1 comment Download
A src/internet/model/tcp-option-end.h View 1 chunk +52 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-end.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-mss.h View 1 chunk +56 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-mss.cc View 1 chunk +100 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-nop.h View 1 chunk +52 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-nop.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-sack.h View 1 chunk +62 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-sack.cc View 1 chunk +118 lines, -0 lines 1 comment Download
A src/internet/model/tcp-option-sack-permitted.h View 1 chunk +52 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-sack-permitted.cc View 1 chunk +84 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-ts.h View 1 chunk +59 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-ts.cc View 1 chunk +114 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-winscale.h View 1 chunk +56 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-winscale.cc View 1 chunk +100 lines, -0 lines 3 comments Download
M src/internet/wscript View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Peter Barnes
Minor suggestions: http://codereview.appspot.com/5452045/diff/1/src/internet/model/tcp-option-sack.cc File src/internet/model/tcp-option-sack.cc (right): http://codereview.appspot.com/5452045/diff/1/src/internet/model/tcp-option-sack.cc#newcode52 src/internet/model/tcp-option-sack.cc:52: { Sack printer would be really useful ...
10 years, 6 months ago (2012-01-04 18:55:18 UTC) #1
Tom Henderson
These need some additional work, since (if I recall correctly the last time I tested ...
8 years, 2 months ago (2014-04-18 17:05:46 UTC) #2
Tom Henderson
8 years, 2 months ago (2014-04-18 17:09:29 UTC) #3
oops, I posted the most recent comments against the wrong issue.

I meant to post against 
https://codereview.appspot.com/24900043

it may be the case that once 24900043 is done, we can pull any additional
options from here (e.g. SackPermitted).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b