Rename Machine to Instance.

Also change machineId from string to int.

https://code.launchpad.net/~rogpeppe/juju/go-juju-machine-to-instance/+merge/84070

(do not edit description out of merge proposal)

[niemeyer, 2011-12-01 08:34:00]

LGTM

Just a detail:

https://codereview.appspot.com/5451060/diff/1/juju/dummyprovider_test.go
File juju/dummyprovider_test.go (right):

https://codereview.appspot.com/5451060/diff/1/juju/dummyprovider_test.go#newc...
juju/dummyprovider_test.go:50: machines map[string]*dummyInstance
As mentioned in the previous review, the key should be an int since it's a
machine id, but the values are instances, so s/machines/instances/ on the field
name.

[rog, 2011-12-01 08:42:30]

https://codereview.appspot.com/5451060/diff/1/juju/dummyprovider_test.go
File juju/dummyprovider_test.go (right):

https://codereview.appspot.com/5451060/diff/1/juju/dummyprovider_test.go#newc...
juju/dummyprovider_test.go:50: machines map[string]*dummyInstance
On 2011/12/01 08:34:00, niemeyer wrote:
> As mentioned in the previous review, the key should be an int since it's a
> machine id, but the values are instances, so s/machines/instances/ on the
field
> name.

instances is right, done.

but the key is right to be a string, i think, as the provider is keeping a set
of instances, not machines. there's no guarantee that there's a one-to-one
mapping between machine id and instance id. (note that in StartInstance, below,
the argument id is ignored; machine id isn't visible anywhere else in the
juju.Instance interface)

[niemeyer, 2011-12-01 09:54:01]

LGTM

https://codereview.appspot.com/5451060/diff/1/juju/dummyprovider_test.go
File juju/dummyprovider_test.go (right):

https://codereview.appspot.com/5451060/diff/1/juju/dummyprovider_test.go#newc...
juju/dummyprovider_test.go:50: machines map[string]*dummyInstance
Makes sense.