Issue 5451047: fix typos

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5451047: fix typos

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by nrhodes

Modified:
2 years ago

Reviewers:
fmela, jjc

CC:
analytics-api-samples-discuss_googlegroups.com

Base URL:
http://analytics-api-samples.googlecode.com/svn/trunk/src/tracking/javascript/v5/social/

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 1

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	ga_social_tracking.js	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	twitter_js_async.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

fmela

LGTM http://www.codereview.appspot.com/5451047/diff/1/ga_social_tracking.js File ga_social_tracking.js (right): http://www.codereview.appspot.com/5451047/diff/1/ga_social_tracking.js#newcode18 ga_social_tracking.js:18: * Ensure global _gaq Google Analytics queue has ...

12 years, 5 months ago (2011-11-30 18:05:02 UTC) #3

nrhodes

On Wed, Nov 30, 2011 at 10:05 AM, <fmela@google.com> wrote: > LGTM > > > ...

12 years, 5 months ago (2011-11-30 18:06:51 UTC) #4

fmela

12 years, 5 months ago (2011-11-30 18:15:48 UTC) #5

On Wed, Nov 30, 2011 at 10:06 AM, Neil Rhodes <nrhodes@google.com> wrote:
>
>
> On Wed, Nov 30, 2011 at 10:05 AM, <fmela@google.com> wrote:
>>
>> LGTM
>>
>>
>> http://www.codereview.appspot.com/5451047/diff/1/ga_social_tracking.js
>> File ga_social_tracking.js (right):
>>
>>
>>
http://www.codereview.appspot.com/5451047/diff/1/ga_social_tracking.js#newcode18
>> ga_social_tracking.js:18: * Ensure global _gaq Google Analytics queue
>> has be initialized.
>> has been
>>
>> http://www.codereview.appspot.com/5451047/
>
>
> Fixed in a separate revision (r19).
>

Thanks!

Expand All Messages | Collapse All Messages