http://codereview.appspot.com/5450114/diff/1/tests/com/google/caja/plugin/es5... File tests/com/google/caja/plugin/es53-test-domado-events-guest.html (right): http://codereview.appspot.com/5450114/diff/1/tests/com/google/caja/plugin/es5... tests/com/google/caja/plugin/es53-test-domado-events-guest.html:19: <p class="clickme testcontainer" id="test-plugin_dispatchEvent"> I would suggest labeling the test in terms of what behavior it is testing, not the implementation detail that implements it. http://codereview.appspot.com/5450114/diff/1/tests/com/google/caja/plugin/es5... tests/com/google/caja/plugin/es53-test-domado-events-guest.html:27: function testPluginDispatchEvent() { }); The string passed to jsunitRegister should be equal to the id and the string passed to pass(). (This doesn't affect our normal test runner but there is a case where it does matter; I forget the details.)
http://codereview.appspot.com/5450114/diff/1/src/com/google/caja/plugin/caja.js File src/com/google/caja/plugin/caja.js (right): http://codereview.appspot.com/5450114/diff/1/src/com/google/caja/plugin/caja.... src/com/google/caja/plugin/caja.js:479: divWindow.plugin_dispatchEvent___ = Let's not pollute the host page name space - can you add this to the caja object and update the plugin handler appropriately? You also need to make sure that works correctly in the es53 case.
this collides with my caja.js refactoring, but it should be the same, uncomment the analagous lines in ses-frame-group.js
On 2011/12/06 23:31:13, Jasvir wrote: > http://codereview.appspot.com/5450114/diff/1/src/com/google/caja/plugin/caja.js > File src/com/google/caja/plugin/caja.js (right): > > http://codereview.appspot.com/5450114/diff/1/src/com/google/caja/plugin/caja.... > src/com/google/caja/plugin/caja.js:479: divWindow.plugin_dispatchEvent___ = > Let's not pollute the host page name space - can you add this to the caja object > and update the plugin handler appropriately? You also need to make sure that > works correctly in the es53 case. Per our discussion, we'll save this for my next CL.