Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(298)

Issue 5450114: Fixes plugin_dispatchEvent in ES5 mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by metaweta
Modified:
14 years, 10 months ago
Reviewers:
felix8a, kpreid2, Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Uncommented some code copied over from ES53 by Kevin, changed it to set plugin_dispatchEvent in the div's window, added a test.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M src/com/google/caja/plugin/caja.js View 1 chunk +7 lines, -7 lines 1 comment Download
M src/com/google/caja/plugin/domado.js View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-events-guest.html View 1 chunk +11 lines, -0 lines 2 comments Download

Messages

Total messages: 5
metaweta
14 years, 10 months ago (2011-12-06 23:06:56 UTC) #1
kpreid2
http://codereview.appspot.com/5450114/diff/1/tests/com/google/caja/plugin/es53-test-domado-events-guest.html File tests/com/google/caja/plugin/es53-test-domado-events-guest.html (right): http://codereview.appspot.com/5450114/diff/1/tests/com/google/caja/plugin/es53-test-domado-events-guest.html#newcode19 tests/com/google/caja/plugin/es53-test-domado-events-guest.html:19: <p class="clickme testcontainer" id="test-plugin_dispatchEvent"> I would suggest labeling the ...
14 years, 10 months ago (2011-12-06 23:16:31 UTC) #2
Jasvir
http://codereview.appspot.com/5450114/diff/1/src/com/google/caja/plugin/caja.js File src/com/google/caja/plugin/caja.js (right): http://codereview.appspot.com/5450114/diff/1/src/com/google/caja/plugin/caja.js#newcode479 src/com/google/caja/plugin/caja.js:479: divWindow.plugin_dispatchEvent___ = Let's not pollute the host page name ...
14 years, 10 months ago (2011-12-06 23:31:13 UTC) #3
felix8a
this collides with my caja.js refactoring, but it should be the same, uncomment the analagous ...
14 years, 10 months ago (2011-12-07 02:03:25 UTC) #4
metaweta
14 years, 10 months ago (2011-12-07 19:24:08 UTC) #5
On 2011/12/06 23:31:13, Jasvir wrote:
>
http://codereview.appspot.com/5450114/diff/1/src/com/google/caja/plugin/caja.js
> File src/com/google/caja/plugin/caja.js (right):
> 
>
http://codereview.appspot.com/5450114/diff/1/src/com/google/caja/plugin/caja....
> src/com/google/caja/plugin/caja.js:479: divWindow.plugin_dispatchEvent___ =
> Let's not pollute the host page name space - can you add this to the caja
object
> and update the plugin handler appropriately?  You also need to make sure that
> works correctly in the es53 case.

Per our discussion, we'll save this for my next CL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b