Issue 5449090: Updated EmailSettings updateVacation to accept start and end dates and domain_only parameters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5449090: Updated EmailSettings updateVacation to accept start and end dates and domain_only parameters

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by shraddhag

Modified:
12 years, 4 months ago

Reviewers:
Claudio Cherubino, jcgregorio

CC:
gdata-python-client-library-contributors_googlegroups.com

Visibility:
Public.

Patch Set 2 : Removed provisioning auth scopes #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -20 lines)			Patch
M	src/gdata/apps/emailsettings/client.py	View		3 chunks	+10 lines, -2 lines	0 comments	Download
M	src/gdata/apps/emailsettings/data.py	View		10 chunks	+93 lines, -10 lines	0 comments	Download
M	tests/gdata_tests/apps/emailsettings/data_test.py	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	tests/gdata_tests/apps/emailsettings/live_client_test.py	View	1	3 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Claudio Cherubino

http://codereview.appspot.com/5449090/diff/1/tests/gdata_tests/apps/emailsettings/live_client_test.py File tests/gdata_tests/apps/emailsettings/live_client_test.py (right): http://codereview.appspot.com/5449090/diff/1/tests/gdata_tests/apps/emailsettings/live_client_test.py#newcode62 tests/gdata_tests/apps/emailsettings/live_client_test.py:62: 'https://apps-apis.google.com/a/feeds/groups/'), self.client.auth_scopes) why are the Provisioning scopes used here?

12 years, 4 months ago (2011-12-05 18:25:00 UTC) #2

shraddhag

12 years, 4 months ago (2011-12-05 18:47:39 UTC) #4

LGTM

Expand All Messages | Collapse All Messages