Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1329)

Issue 5449071: code review 5449071: various: shorten composite literal field values (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by rsc
Modified:
7 years, 1 month ago
Reviewers:
gustavo, dfc, r, adg, r2, golang-dev, gri, bradfitz
Visibility:
Public.

Description

various: shorten composite literal field values

Patch Set 1 #

Patch Set 2 : diff -r 9dd360edbed9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f91f50b96e10 https://go.googlecode.com/hg/ #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M src/pkg/archive/zip/writer.go View 1 2 chunks +2 lines, -2 lines 1 comment Download
M src/pkg/encoding/xml/xml.go View 1 2 chunks +2 lines, -2 lines 1 comment Download
M src/pkg/exp/norm/readwriter.go View 1 2 chunks +2 lines, -2 lines 1 comment Download
M src/pkg/exp/sql/sql.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/pkg/exp/ssh/transport.go View 1 1 chunk +4 lines, -4 lines 2 comments Download
M src/pkg/go/build/build.go View 1 7 chunks +15 lines, -15 lines 1 comment Download
M src/pkg/html/parse.go View 1 2 chunks +2 lines, -2 lines 1 comment Download
M src/pkg/html/template/escape.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/pkg/math/big/rat.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/pkg/old/netchan/export.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/pkg/testing/benchmark.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/pkg/text/template/exec.go View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 16
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 1 month ago (2011-12-02 20:01:22 UTC) #1
r
LGTM
7 years, 1 month ago (2011-12-02 20:47:15 UTC) #2
dfc
LVGTM http://codereview.appspot.com/5449071/diff/5001/src/pkg/exp/ssh/transport.go File src/pkg/exp/ssh/transport.go (right): http://codereview.appspot.com/5449071/diff/5001/src/pkg/exp/ssh/transport.go#newcode224 src/pkg/exp/ssh/transport.go:224: reader: { Excellent.
7 years, 1 month ago (2011-12-02 20:49:41 UTC) #3
gri
I may be the only one here, but I am not really liking these changes. ...
7 years, 1 month ago (2011-12-02 21:23:25 UTC) #4
rsc
On Fri, Dec 2, 2011 at 16:23, Robert Griesemer <gri@golang.org> wrote: > I may be ...
7 years, 1 month ago (2011-12-02 21:24:48 UTC) #5
bradfitz
Personally, I like fixing the ones were the type is obvious: - Args: []string{"mkdir", "-p", ...
7 years, 1 month ago (2011-12-02 21:53:10 UTC) #6
gri
FYI. http://codereview.appspot.com/5449071/diff/5001/src/pkg/archive/zip/writer.go File src/pkg/archive/zip/writer.go (left): http://codereview.appspot.com/5449071/diff/5001/src/pkg/archive/zip/writer.go#oldcode35 src/pkg/archive/zip/writer.go:35: return &Writer{countWriter: &countWriter{w: bufio.NewWriter(w)}} I'd leave this file ...
7 years, 1 month ago (2011-12-02 23:04:18 UTC) #7
gustavo_niemeyer.net
>> I may be the only one here, but I am not really liking these ...
7 years, 1 month ago (2011-12-02 23:11:46 UTC) #8
gri
On Fri, Dec 2, 2011 at 3:11 PM, Gustavo Niemeyer <gustavo@niemeyer.net> wrote: > I've been ...
7 years, 1 month ago (2011-12-03 01:31:50 UTC) #9
gustavo_niemeyer.net
On Fri, Dec 2, 2011 at 23:31, Robert Griesemer <gri@golang.org> wrote: > +1 > > ...
7 years, 1 month ago (2011-12-03 02:32:00 UTC) #10
gustavo_niemeyer.net
> Another problematic one regards the difference between slices and > structs. It used to ...
7 years, 1 month ago (2011-12-03 02:40:44 UTC) #11
r2
This new ability allows code to be more concise but not always more readable. I'm ...
7 years, 1 month ago (2011-12-03 05:39:15 UTC) #12
gustavo_niemeyer.net
> This new ability allows code to be more concise but not always more readable. ...
7 years, 1 month ago (2011-12-03 14:11:13 UTC) #13
adg
On 3 December 2011 16:39, Rob 'Commander' Pike <r@google.com> wrote: > This new ability allows ...
7 years, 1 month ago (2011-12-03 21:56:59 UTC) #14
r2
On Dec 3, 2011, at 1:56 PM, Andrew Gerrand wrote: > On 3 December 2011 ...
7 years, 1 month ago (2011-12-03 22:00:08 UTC) #15
rsc
7 years, 1 month ago (2011-12-05 19:03:58 UTC) #16
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b