code review 5449070: net: shorten composite literal field values

net: shorten composite literal field values

[rsc, 2011-12-02 20:01:14]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-12-02 20:46:13]

LGTM

[gri, 2011-12-02 23:06:26]

FYI

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/dict/dict.go
File src/pkg/net/dict/dict.go (right):

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/dict/dict.go#newc...
src/pkg/net/dict/dict.go:130: d := &Defn{Word: a[0], Dict: {a[1], a[2]}}
I'd leave this file alone - no real win

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/http/fcgi/child.go
File src/pkg/net/http/fcgi/child.go (right):

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/http/fcgi/child.g...
src/pkg/net/http/fcgi/child.go:34: params:   {},
I'd leave this file alone - no real win

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/http/filetranspor...
File src/pkg/net/http/filetransport.go (right):

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/http/filetranspor...
src/pkg/net/http/filetransport.go:54: res: {
I'd leave this file alone - no real win

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/http/httptest/ser...
File src/pkg/net/http/httptest/server.go (right):

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/http/httptest/ser...
src/pkg/net/http/httptest/server.go:85: Config:   {Handler: handler},
I'd leave this file alone - no real win

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/http/server.go
File src/pkg/net/http/server.go (right):

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/http/server.go#ne...
src/pkg/net/http/server.go:1087: NextProtos: {"http/1.1"},
I'd leave this file alone - no real win

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/http/transport.go
File src/pkg/net/http/transport.go (right):

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/http/transport.go...
src/pkg/net/http/transport.go:335: URL:    {RawPath: cm.targetAddr},
I'd leave this file alone - no real win

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/textproto/textpro...
File src/pkg/net/textproto/textproto.go (right):

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/textproto/textpro...
src/pkg/net/textproto/textproto.go:65: Reader: {R: bufio.NewReader(conn)},
I'd leave this file alone - no real win

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/udpsock_posix.go
File src/pkg/net/udpsock_posix.go (right):

http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/udpsock_posix.go#...
src/pkg/net/udpsock_posix.go:275: mreq := &syscall.IPMreq{Multiaddr: {ip[0],
ip[1], ip[2], ip[3]}}
I'd leave this file alone - no real win

[rsc, 2011-12-05 19:04:04]

*** Abandoned ***