Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(277)

Issue 5449070: code review 5449070: net: shorten composite literal field values (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by rsc
Modified:
7 years, 1 month ago
Reviewers:
r, gri, golang-dev
Visibility:
Public.

Description

net: shorten composite literal field values

Patch Set 1 #

Patch Set 2 : diff -r 9dd360edbed9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f91f50b96e10 https://go.googlecode.com/hg/ #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/pkg/net/dict/dict.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/pkg/net/http/fcgi/child.go View 1 2 chunks +2 lines, -2 lines 1 comment Download
M src/pkg/net/http/filetransport.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/pkg/net/http/httptest/server.go View 1 2 chunks +3 lines, -3 lines 1 comment Download
M src/pkg/net/http/server.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/pkg/net/http/transport.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/pkg/net/textproto/textproto.go View 1 1 chunk +2 lines, -2 lines 1 comment Download
M src/pkg/net/udpsock_posix.go View 1 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 1 month ago (2011-12-02 20:01:14 UTC) #1
r
LGTM
7 years, 1 month ago (2011-12-02 20:46:13 UTC) #2
gri
FYI http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/dict/dict.go File src/pkg/net/dict/dict.go (right): http://codereview.appspot.com/5449070/diff/3001/src/pkg/net/dict/dict.go#newcode130 src/pkg/net/dict/dict.go:130: d := &Defn{Word: a[0], Dict: {a[1], a[2]}} I'd ...
7 years, 1 month ago (2011-12-02 23:06:26 UTC) #3
rsc
7 years, 1 month ago (2011-12-05 19:04:04 UTC) #4
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b