Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(857)

Issue 5449065: juju/ec2: add code to accept an ec2 region in the configuration file.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by rog
Modified:
8 years, 7 months ago
Reviewers:
mp+84256
Visibility:
Public.

Description

https://code.launchpad.net/~rogpeppe/juju/go-juju-ec2-region/+merge/84256 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Total comments: 10

Patch Set 4 : - #

Patch Set 5 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -47 lines) Patch
M juju/ec2/Makefile View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A juju/ec2/config.go View 1 2 3 4 1 chunk +58 lines, -0 lines 0 comments Download
A juju/ec2/config_test.go View 1 2 3 4 1 chunk +54 lines, -0 lines 0 comments Download
M juju/ec2/ec2.go View 1 2 3 4 3 chunks +2 lines, -15 lines 0 comments Download
D juju/ec2/ec2_test.go View 1 2 3 4 1 chunk +0 lines, -32 lines 0 comments Download
A juju/ec2/juju_test.go View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
A juju/ec2/suite_test.go View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
A juju/ec2/util.go View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 7
niemeyer
Please propose it again so that we get the real diff.
8 years, 7 months ago (2011-12-02 16:13:05 UTC) #1
niemeyer
https://codereview.appspot.com/5449065/diff/5001/juju/ec2/config.go File juju/ec2/config.go (right): https://codereview.appspot.com/5449065/diff/5001/juju/ec2/config.go#newcode27 juju/ec2/config.go:27: "us-west-1": aws.USWest, This changes is a bit precipitated. First, ...
8 years, 7 months ago (2011-12-06 02:37:32 UTC) #2
rog
https://codereview.appspot.com/5449065/diff/5001/juju/ec2/config.go File juju/ec2/config.go (right): https://codereview.appspot.com/5449065/diff/5001/juju/ec2/config.go#newcode27 juju/ec2/config.go:27: "us-west-1": aws.USWest, On 2011/12/06 02:37:32, niemeyer wrote: > This ...
8 years, 7 months ago (2011-12-06 09:31:00 UTC) #3
niemeyer
LGTM https://codereview.appspot.com/5449065/diff/5001/juju/ec2/config.go File juju/ec2/config.go (right): https://codereview.appspot.com/5449065/diff/5001/juju/ec2/config.go#newcode21 juju/ec2/config.go:21: // TODO move these known strings into goamz/aws? ...
8 years, 7 months ago (2011-12-06 11:37:56 UTC) #4
rog
(test changed to use FitsTypeOf too.) https://codereview.appspot.com/5449065/diff/5001/juju/ec2/config.go File juju/ec2/config.go (right): https://codereview.appspot.com/5449065/diff/5001/juju/ec2/config.go#newcode30 juju/ec2/config.go:30: // AddRegion adds ...
8 years, 7 months ago (2011-12-06 12:22:46 UTC) #5
niemeyer
LGTM, thanks!
8 years, 7 months ago (2011-12-06 12:29:02 UTC) #6
niemeyer
8 years, 7 months ago (2011-12-13 21:58:46 UTC) #7
This was merged already.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b