Issue 5449064: CPP: Remove static non-POD variables from RegionCode class.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5449064: CPP: Remove static non-POD variables from RegionCode class. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by philippe

Modified:
12 years, 5 months ago

Reviewers:
Shaopeng

CC:
lararennie, georgey1

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

CPP: Remove static non-POD variables from RegionCode class. Patch contributed by georgey@chromium.org. Committed: http://code.google.com/p/libphonenumber/source/detail?r=406

Patch Set 1 #

Patch Set 2 : Sync #

Patch Set 3 : Add comment in test_util.h #

Patch Set 4 : Fix typo #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -71 lines)			Patch
	M	cpp/src/phonenumbers/region_code.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	cpp/test/phonenumbers/test_util.h	View	1 2 3	1 chunk	+48 lines, -68 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

I added a comment Lara in test_util.h.

Expand All Messages | Collapse All Messages