code review 5448130: time: fix daysIn for December

time: fix daysIn for December

daysBefore[12+1]: index out of range
time.December and Windows SYSTEMTIME.wMonth
are 12 for December.

[peterGo, 2011-12-07 09:33:02]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2011-12-07 11:36:17]

Add a test please.

[peterGo, 2011-12-07 17:01:38]

On 2011/12/07 11:36:17, dsymonds wrote:
> Add a test please.

How? daysIn is not exported.

Peter

[rsc, 2011-12-07 17:14:02]

On Wed, Dec 7, 2011 at 12:01,  <go.peter.90@gmail.com> wrote:
> How? daysIn is not exported.

You can call a function that would end up using it
in the way that crashes.  That is the best way.
You can also add a line to internal_test.go to
"export" it during the tests.

Russ

[peterGo, 2011-12-07 19:26:35]

Hello rsc@golang.org, dsymonds@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-12-07 19:34:08]

hg file 5448130 time_test.go && hg mail 5448130?

On Wed, Dec 7, 2011 at 14:26,  <go.peter.90@gmail.com> wrote:
> Hello rsc@golang.org, dsymonds@golang.org (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
> http://codereview.appspot.com/5448130/

[peterGo, 2011-12-07 19:38:06]

Hello rsc@golang.org, dsymonds@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-12-07 19:46:45]

LGTM

Thanks.

[rsc, 2011-12-07 19:47:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=58e8002fa982 ***

time: fix daysIn for December

daysBefore[12+1]: index out of range
time.December and Windows SYSTEMTIME.wMonth
are 12 for December.

R=rsc, dsymonds
CC=golang-dev
http://codereview.appspot.com/5448130

Committer: Russ Cox <rsc@golang.org>