Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(318)

Issue 5448089: code review 5448089: crypto: shorten composite literal field values (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by rsc
Modified:
7 years, 1 month ago
Reviewers:
agl1, r, gri, bradfitz
CC:
golang-dev
Visibility:
Public.

Description

crypto: shorten composite literal field values

Patch Set 1 #

Patch Set 2 : diff -r 9dd360edbed9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f91f50b96e10 https://go.googlecode.com/hg/ #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M src/pkg/crypto/openpgp/keys.go View 1 2 chunks +2 lines, -2 lines 1 comment Download
M src/pkg/crypto/openpgp/packet/reader.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/pkg/crypto/tls/handshake_client.go View 1 1 chunk +3 lines, -3 lines 1 comment Download
M src/pkg/crypto/x509/x509.go View 1 5 chunks +12 lines, -12 lines 1 comment Download

Messages

Total messages: 5
rsc
Hello agl1, bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 1 month ago (2011-12-02 20:00:48 UTC) #1
agl1
LGTM
7 years, 1 month ago (2011-12-02 20:03:50 UTC) #2
r
LGTM that was a good set
7 years, 1 month ago (2011-12-02 20:47:45 UTC) #3
gri
FYI. http://codereview.appspot.com/5448089/diff/4001/src/pkg/crypto/openpgp/keys.go File src/pkg/crypto/openpgp/keys.go (right): http://codereview.appspot.com/5448089/diff/4001/src/pkg/crypto/openpgp/keys.go#newcode407 src/pkg/crypto/openpgp/keys.go:407: SelfSignature: { I'd leave this file alone - ...
7 years, 1 month ago (2011-12-02 23:07:40 UTC) #4
rsc
7 years, 1 month ago (2011-12-05 19:04:09 UTC) #5
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b