Issue 5448089: code review 5448089: crypto: shorten composite literal field values

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5448089: code review 5448089: crypto: shorten composite literal field values (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by rsc

Modified:
12 years, 11 months ago

Reviewers:
agl1, r, gri, bradfitz

CC:
golang-dev

Visibility:
Public.

Description

crypto: shorten composite literal field values

Patch Set 2 : diff -r 9dd360edbed9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f91f50b96e10 https://go.googlecode.com/hg/ #

Total comments: 4

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -18 lines)			Patch
M	src/pkg/crypto/openpgp/keys.go	View	1	2 chunks	+2 lines, -2 lines	1 comment	Download
M	src/pkg/crypto/openpgp/packet/reader.go	View	1	1 chunk	+1 line, -1 line	1 comment	Download
M	src/pkg/crypto/tls/handshake_client.go	View	1	1 chunk	+3 lines, -3 lines	1 comment	Download
M	src/pkg/crypto/x509/x509.go	View	1	5 chunks	+12 lines, -12 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello agl1, bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2011-12-02 20:00:48 UTC) #1

gri

FYI. http://codereview.appspot.com/5448089/diff/4001/src/pkg/crypto/openpgp/keys.go File src/pkg/crypto/openpgp/keys.go (right): http://codereview.appspot.com/5448089/diff/4001/src/pkg/crypto/openpgp/keys.go#newcode407 src/pkg/crypto/openpgp/keys.go:407: SelfSignature: { I'd leave this file alone - ...

12 years, 11 months ago (2011-12-02 23:07:40 UTC) #4

*** Abandoned ***

Expand All Messages | Collapse All Messages