Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1155)

Issue 5448088: code review 5448088: cmd: shorten composite literal field values (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by rsc
Modified:
7 years, 1 month ago
Reviewers:
r, gri, golang-dev
Visibility:
Public.

Description

cmd: shorten composite literal field values

Patch Set 1 #

Patch Set 2 : diff -r 9dd360edbed9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f91f50b96e10 https://go.googlecode.com/hg/ #

Total comments: 18
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -93 lines) Patch
M src/cmd/cgo/gcc.go View 1 2 4 chunks +6 lines, -6 lines 2 comments Download
M src/cmd/cgo/util.go View 1 2 1 chunk +1 line, -1 line 1 comment Download
M src/cmd/gofix/error.go View 1 1 chunk +3 lines, -3 lines 1 comment Download
M src/cmd/gofix/filepath.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/cmd/gofix/fix.go View 1 2 chunks +2 lines, -2 lines 1 comment Download
M src/cmd/gofix/hashsum.go View 1 3 chunks +4 lines, -4 lines 1 comment Download
M src/cmd/gofix/htmlerr.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/cmd/gofix/httpfs.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/cmd/gofix/httpheaders.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/cmd/gofix/imagenew.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/cmd/gofix/mapdelete.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/cmd/gofix/reflect.go View 1 9 chunks +56 lines, -56 lines 1 comment Download
M src/cmd/gofix/template.go View 1 3 chunks +4 lines, -4 lines 1 comment Download
M src/cmd/gofix/timefileinfo.go View 1 2 chunks +5 lines, -5 lines 1 comment Download
M src/cmd/gofix/typecheck.go View 1 1 chunk +1 line, -1 line 1 comment Download
M src/cmd/goinstall/download.go View 1 2 4 chunks +4 lines, -4 lines 1 comment Download
M src/cmd/gotest/gotest.go View 1 2 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 1 month ago (2011-12-02 20:01:07 UTC) #1
r
not so sure about the ast ones in gofix. with that detail gone, it's harder ...
7 years, 1 month ago (2011-12-02 20:45:32 UTC) #2
gri
I am not sure I like these, either. The code becomes unreadable if one is ...
7 years, 1 month ago (2011-12-02 21:19:58 UTC) #3
gri
FYI http://codereview.appspot.com/5448088/diff/3/src/cmd/cgo/gcc.go File src/cmd/cgo/gcc.go (right): http://codereview.appspot.com/5448088/diff/3/src/cmd/cgo/gcc.go#newcode1312 src/cmd/cgo/gcc.go:1312: Go: { unreadable http://codereview.appspot.com/5448088/diff/3/src/cmd/cgo/gcc.go#newcode1417 src/cmd/cgo/gcc.go:1417: fld[n] = &ast.Field{Names: ...
7 years, 1 month ago (2011-12-02 23:11:04 UTC) #4
rsc
7 years, 1 month ago (2011-12-05 19:04:14 UTC) #5
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b