code review 5448088: cmd: shorten composite literal field values

cmd: shorten composite literal field values

[rsc, 2011-12-02 20:01:07]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-12-02 20:45:32]

not so sure about the ast ones in gofix. with that detail gone, it's harder to
see what's going on.

[gri, 2011-12-02 21:19:58]

I am not sure I like these, either. The code becomes unreadable if one is not
familiar with the data structures.

[gri, 2011-12-02 23:11:04]

FYI

http://codereview.appspot.com/5448088/diff/3/src/cmd/cgo/gcc.go
File src/cmd/cgo/gcc.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/cgo/gcc.go#newcode1312
src/cmd/cgo/gcc.go:1312: Go: {
unreadable

http://codereview.appspot.com/5448088/diff/3/src/cmd/cgo/gcc.go#newcode1417
src/cmd/cgo/gcc.go:1417: fld[n] = &ast.Field{Names: {c.Ident(ident[name])},
Type: tgo}
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/cgo/util.go
File src/cmd/cgo/util.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/cgo/util.go#newcode35
src/cmd/cgo/util.go:35: p, err := os.StartProcess(cmd, argv, &os.ProcAttr{Files:
{r0, w1, w2}})
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/error.go
File src/cmd/gofix/error.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/error.go#newcode90
src/cmd/gofix/error.go:90: Type: {
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/filepath.go
File src/cmd/gofix/filepath.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/filepath.go#newcode49
src/cmd/gofix/filepath.go:49: Args: {ast.NewIdent(ident)},
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/fix.go
File src/cmd/gofix/fix.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/fix.go#newcode477
src/cmd/gofix/fix.go:477: Sel: {
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/hashsum.go
File src/cmd/gofix/hashsum.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/hashsum.go#newcode32
src/cmd/gofix/hashsum.go:32: Var: {
I'd leave this file alone - no real win
especially compared to the size of the tables

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/htmlerr.go
File src/cmd/gofix/htmlerr.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/htmlerr.go#newcode26
src/cmd/gofix/htmlerr.go:26: Func: {
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/httpfs.go
File src/cmd/gofix/httpfs.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/httpfs.go#newcode43
src/cmd/gofix/httpfs.go:43: Args: {dir},
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/httpheaders.go
File src/cmd/gofix/httpheaders.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/httpheaders.go#new...
src/cmd/gofix/httpheaders.go:63: Type: {
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/imagenew.go
File src/cmd/gofix/imagenew.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/imagenew.go#newcode72
src/cmd/gofix/imagenew.go:72: Sel: {
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/mapdelete.go
File src/cmd/gofix/mapdelete.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/mapdelete.go#newco...
src/cmd/gofix/mapdelete.go:52: Args: {ix.X, ix.Index},
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/reflect.go
File src/cmd/gofix/reflect.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/reflect.go#newcode243
src/cmd/gofix/reflect.go:243: Args: {
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/template.go
File src/cmd/gofix/template.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/template.go#newcode42
src/cmd/gofix/template.go:42: Type: {
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/timefileinfo.go
File src/cmd/gofix/timefileinfo.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/timefileinfo.go#ne...
src/cmd/gofix/timefileinfo.go:32: Type: {
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/typecheck.go
File src/cmd/gofix/typecheck.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gofix/typecheck.go#newco...
src/cmd/gofix/typecheck.go:197: t := &Type{Field: {}}
I'd leave this file alone - no real win

http://codereview.appspot.com/5448088/diff/3/src/cmd/goinstall/download.go
File src/cmd/goinstall/download.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/goinstall/download.go#ne...
src/cmd/goinstall/download.go:77: protocols: {"https", "http"},
maybe

http://codereview.appspot.com/5448088/diff/3/src/cmd/gotest/gotest.go
File src/cmd/gotest/gotest.go (right):

http://codereview.appspot.com/5448088/diff/3/src/cmd/gotest/gotest.go#newcode322
src/cmd/gotest/gotest.go:322: Files: {
I'd leave this file alone - no real win

[rsc, 2011-12-05 19:04:14]

*** Abandoned ***