Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(113)

Issue 5448067: code review 5448067: weekly.2011-12-01 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by adg
Modified:
11 years ago
Reviewers:
dsymonds, dvyukov
CC:
golang-dev, r
Visibility:
Public.

Description

weekly.2011-12-01

Patch Set 1 #

Total comments: 6

Patch Set 2 : diff -r 69cec8583a92 https://go.googlecode.com/hg #

Total comments: 1

Patch Set 3 : diff -r b295fb8acebe https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 1 chunk +131 lines, -0 lines 0 comments Download

Messages

Total messages: 7
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
11 years ago (2011-12-01 03:46:21 UTC) #1
r
http://codereview.appspot.com/5448067/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5448067/diff/1/doc/devel/weekly.html#newcode21 doc/devel/weekly.html:21: package time and package os and changes to package ...
11 years ago (2011-12-01 03:51:45 UTC) #2
adg
http://codereview.appspot.com/5448067/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5448067/diff/1/doc/devel/weekly.html#newcode21 doc/devel/weekly.html:21: package time and package os and changes to package ...
11 years ago (2011-12-01 04:06:13 UTC) #3
r
LGTM http://codereview.appspot.com/5448067/diff/2002/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5448067/diff/2002/doc/devel/weekly.html#newcode103 doc/devel/weekly.html:103: code that uses Set will need to be ...
11 years ago (2011-12-01 04:11:17 UTC) #4
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=80db2da6495a *** weekly.2011-12-01 R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5448067
11 years ago (2011-12-01 05:17:30 UTC) #5
dsymonds
This missed the time.Time gofix (http://codereview.appspot.com/5450050/ is not submitted yet). Can you tag a new ...
11 years ago (2011-12-01 07:27:13 UTC) #6
dvyukov
11 years ago (2011-12-01 08:58:02 UTC) #7
On Thu, Dec 1, 2011 at 11:27 AM, David Symonds <dsymonds@golang.org> wrote:

> This missed the time.Time gofix
> (http://codereview.appspot.com/5450050/ is not submitted yet). Can you
> tag a new weekly tomorrow?
>

Just in case, cgo on Windows is still broken...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b