code review 5448067: weekly.2011-12-01

weekly.2011-12-01

[adg, 2011-12-01 03:46:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[r, 2011-12-01 03:51:45]

http://codereview.appspot.com/5448067/diff/1/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5448067/diff/1/doc/devel/weekly.html#newcode21
doc/devel/weekly.html:21: package time and package os and changes to package
text/template.
very hard to parse.

http://codereview.appspot.com/5448067/diff/1/doc/devel/weekly.html#newcode100
doc/devel/weekly.html:100: THe html/template package has been updated also.
s/H/h/

there's a gofix for the simplest and most common use of the old API. code that
doesn't mention the Set type is likely to work after running gofix; code that
uses Set will need to be updated by hand.

http://codereview.appspot.com/5448067/diff/1/doc/devel/weekly.html#newcode112
doc/devel/weekly.html:112: * dashboard: start a Go implementation of the App
Engine app.
unclear and don't say app twice

start of reimplementation in Go for App Engine.

[adg, 2011-12-01 04:06:13]

http://codereview.appspot.com/5448067/diff/1/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5448067/diff/1/doc/devel/weekly.html#newcode21
doc/devel/weekly.html:21: package time and package os and changes to package
text/template.
On 2011/12/01 03:51:45, r wrote:
> very hard to parse.

Rewritten.

http://codereview.appspot.com/5448067/diff/1/doc/devel/weekly.html#newcode100
doc/devel/weekly.html:100: THe html/template package has been updated also.
On 2011/12/01 03:51:45, r wrote:
> s/H/h/
> 
> there's a gofix for the simplest and most common use of the old API. code that
> doesn't mention the Set type is likely to work after running gofix; code that
> uses Set will need to be updated by hand.

Done.

http://codereview.appspot.com/5448067/diff/1/doc/devel/weekly.html#newcode112
doc/devel/weekly.html:112: * dashboard: start a Go implementation of the App
Engine app.
On 2011/12/01 03:51:45, r wrote:
> unclear and don't say app twice
> 
> start of reimplementation in Go for App Engine.

Done.

[r, 2011-12-01 04:11:17]

LGTM

http://codereview.appspot.com/5448067/diff/2002/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5448067/diff/2002/doc/devel/weekly.html#newcode103
doc/devel/weekly.html:103: code that uses Set will need to be updated by hand.
The template definition language itself is unchanged.

[adg, 2011-12-01 05:17:30]

*** Submitted as http://code.google.com/p/go/source/detail?r=80db2da6495a ***

weekly.2011-12-01

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5448067

[dsymonds, 2011-12-01 07:27:13]

This missed the time.Time gofix
(http://codereview.appspot.com/5450050/ is not submitted yet). Can you
tag a new weekly tomorrow?

[dvyukov, 2011-12-01 08:58:02]

On Thu, Dec 1, 2011 at 11:27 AM, David Symonds <dsymonds@golang.org> wrote:

> This missed the time.Time gofix
> (http://codereview.appspot.com/5450050/ is not submitted yet). Can you
> tag a new weekly tomorrow?
>

Just in case, cgo on Windows is still broken...