Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3023)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5447068: Add Android MobilePlayground.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by jjc
Modified:
2 years ago
Reviewers:
nrhodes, fmela
CC:
analytics-api-samples-discuss_googlegroups.com
Base URL:
http://analytics-api-samples.googlecode.com/svn/trunk/src/tracking/mobile/android/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Remove files that shouldn't be uploaded. #

Total comments: 6

Patch Set 3 : Removed TODOs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2084 lines, -0 lines) Patch
A AndroidManifest.xml View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A COPYING View 1 1 chunk +202 lines, -0 lines 0 comments Download
A README View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A libs/copy-libGoogleAnalytics-jar-into-here.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A project.properties View 1 1 chunk +11 lines, -0 lines 0 comments Download
A res/drawable/icon.png View 1 Binary file 0 comments Download
A res/drawable/tab.xml View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A res/drawable/tab_selected.png View 1 Binary file 0 comments Download
A res/drawable/tab_unselected.png View 1 Binary file 0 comments Download
A res/layout/customvar.xml View 1 2 1 chunk +88 lines, -0 lines 0 comments Download
A res/layout/ecommerce.xml View 1 2 1 chunk +172 lines, -0 lines 0 comments Download
A res/layout/event.xml View 1 2 1 chunk +113 lines, -0 lines 0 comments Download
A res/layout/main.xml View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A res/layout/pageview.xml View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A res/layout/referrer.xml View 1 2 1 chunk +96 lines, -0 lines 0 comments Download
A res/layout/settings.xml View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
A res/values/strings.xml View 1 2 1 chunk +154 lines, -0 lines 0 comments Download
A src/com/google/android/apps/analytics/examples/mobileplayground/CustomVarActivity.java View 1 1 chunk +150 lines, -0 lines 0 comments Download
A src/com/google/android/apps/analytics/examples/mobileplayground/EcommerceActivity.java View 1 1 chunk +250 lines, -0 lines 0 comments Download
A src/com/google/android/apps/analytics/examples/mobileplayground/EventActivity.java View 1 1 chunk +138 lines, -0 lines 0 comments Download
A src/com/google/android/apps/analytics/examples/mobileplayground/MobilePlayground.java View 1 1 chunk +91 lines, -0 lines 0 comments Download
A src/com/google/android/apps/analytics/examples/mobileplayground/PageviewActivity.java View 1 1 chunk +102 lines, -0 lines 0 comments Download
A src/com/google/android/apps/analytics/examples/mobileplayground/ReferrerActivity.java View 1 1 chunk +142 lines, -0 lines 0 comments Download
A src/com/google/android/apps/analytics/examples/mobileplayground/SettingsActivity.java View 1 1 chunk +134 lines, -0 lines 0 comments Download

Messages

Total messages: 6
jjc
12 years, 5 months ago (2011-12-01 21:08:23 UTC) #1
jjc
12 years, 5 months ago (2011-12-01 23:22:30 UTC) #2
nrhodes
http://codereview.appspot.com/5447068/diff/4002/AndroidManifest.xml File AndroidManifest.xml (right): http://codereview.appspot.com/5447068/diff/4002/AndroidManifest.xml#newcode11 AndroidManifest.xml:11: <!-- TODO(aihawkins): Get correct icon --> What do we ...
12 years, 5 months ago (2011-12-01 23:26:17 UTC) #3
jjc
12 years, 5 months ago (2011-12-02 17:59:37 UTC) #4
jjc
http://codereview.appspot.com/5447068/diff/4002/AndroidManifest.xml File AndroidManifest.xml (right): http://codereview.appspot.com/5447068/diff/4002/AndroidManifest.xml#newcode11 AndroidManifest.xml:11: <!-- TODO(aihawkins): Get correct icon --> On 2011/12/01 23:26:17, ...
12 years, 5 months ago (2011-12-02 18:00:13 UTC) #5
nrhodes
12 years, 4 months ago (2011-12-05 17:29:53 UTC) #6 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b