Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11390)

Issue 5445048: package renaming tentative: zk -> zookeeper

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by mpl
Modified:
12 years, 5 months ago
Reviewers:
mp+83695, niemeyer
Visibility:
Public.

Description

updated the package names for the tests as well, as per Gustavo's comments. https://code.launchpad.net/~mathieu-lonjaret/gozk/zookeeper/+merge/83695 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M retry_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M server.go View 1 1 chunk +1 line, -1 line 0 comments Download
M suite_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M zk.go View 1 1 chunk +1 line, -1 line 0 comments Download
M zk_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
niemeyer
LGTM Just one detail: https://codereview.appspot.com/5445048/diff/1/zk_test.go File zk_test.go (right): https://codereview.appspot.com/5445048/diff/1/zk_test.go#newcode1 zk_test.go:1: package zk_test The package name ...
12 years, 5 months ago (2011-11-29 13:11:45 UTC) #1
mpl
Done. On 2011/11/29 13:11:45, niemeyer wrote: > LGTM > > Just one detail: > > ...
12 years, 5 months ago (2011-11-29 15:10:04 UTC) #2
niemeyer
LGTM Will get it merge, thanks a lot Mathieu.
12 years, 5 months ago (2011-11-29 15:36:10 UTC) #3
niemeyer
12 years, 5 months ago (2011-12-01 11:59:52 UTC) #4

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b