Add EasyTracking code to NotePad sample application.

[nrhodes, 2011-11-28 17:37:08]

http://codereview.appspot.com/5443046/diff/1/NotePad/AndroidManifest.xml
File NotePad/AndroidManifest.xml (right):

http://codereview.appspot.com/5443046/diff/1/NotePad/AndroidManifest.xml#newc...
NotePad/AndroidManifest.xml:25: <uses-permission
android:name="android.permission.INTERNET" />
Add comment before these two lines that we're adding these permissions for
analytics.

http://codereview.appspot.com/5443046/diff/1/NotePad/res/values/GoogleAnalyti...
File NotePad/res/values/GoogleAnalytics.xml (right):

http://codereview.appspot.com/5443046/diff/1/NotePad/res/values/GoogleAnalyti...
NotePad/res/values/GoogleAnalytics.xml:3: <!-- Replace place-holder GA API key
with a real one. -->
placeholder

http://codereview.appspot.com/5443046/diff/1/NotePad/res/values/GoogleAnalyti...
NotePad/res/values/GoogleAnalytics.xml:6: <bool name="ga_debug">true</bool>
I'd add comments for all these.

http://codereview.appspot.com/5443046/diff/1/NotePad/res/values/GoogleAnalyti...
NotePad/res/values/GoogleAnalytics.xml:9: <integer
name="ga_dispatchPeriod">5</integer>
5 seems *very* small.

http://codereview.appspot.com/5443046/diff/1/NotePad/res/values/GoogleAnalyti...
NotePad/res/values/GoogleAnalytics.xml:11: <string
name="com.example.android.notepad.NoteEditor">NoteEditor</string>
Add comment that we're mapping the class name to the reported name.

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
File NotePad/src/com/example/android/notepad/NoteEditor.java (right):

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
NotePad/src/com/example/android/notepad/NoteEditor.java:19: import
com.google.android.apps.analytics.easytracking.TrackedActivity;
put *after* com.example...
(so it's in alphabetical order).

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
NotePad/src/com/example/android/notepad/NoteEditor.java:110: public void
onCreate(Bundle savedInstanceState) {
Once you fix TrackedActivity, you can leave this protected.

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
File NotePad/src/com/example/android/notepad/NotesList.java (right):

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
NotePad/src/com/example/android/notepad/NotesList.java:19: import
com.google.android.apps.analytics.easytracking.TrackedListActivity;
re-order.

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
NotePad/src/com/example/android/notepad/NotesList.java:63: public void
onCreate(Bundle savedInstanceState) {
leave as protected

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
File NotePad/src/com/example/android/notepad/TitleEditor.java (right):

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
NotePad/src/com/example/android/notepad/TitleEditor.java:19: import
com.google.android.apps.analytics.easytracking.TrackedActivity;
reorder.

[jjc, 2011-11-28 17:49:17]

http://codereview.appspot.com/5443046/diff/1/NotePad/AndroidManifest.xml
File NotePad/AndroidManifest.xml (right):

http://codereview.appspot.com/5443046/diff/1/NotePad/AndroidManifest.xml#newc...
NotePad/AndroidManifest.xml:25: <uses-permission
android:name="android.permission.INTERNET" />
On 2011/11/28 17:37:08, nrhodes wrote:
> Add comment before these two lines that we're adding these permissions for
> analytics.

Done.

http://codereview.appspot.com/5443046/diff/1/NotePad/res/values/GoogleAnalyti...
File NotePad/res/values/GoogleAnalytics.xml (right):

http://codereview.appspot.com/5443046/diff/1/NotePad/res/values/GoogleAnalyti...
NotePad/res/values/GoogleAnalytics.xml:3: <!-- Replace place-holder GA API key
with a real one. -->
On 2011/11/28 17:37:08, nrhodes wrote:
> placeholder

Done.

http://codereview.appspot.com/5443046/diff/1/NotePad/res/values/GoogleAnalyti...
NotePad/res/values/GoogleAnalytics.xml:6: <bool name="ga_debug">true</bool>
On 2011/11/28 17:37:08, nrhodes wrote:
> I'd add comments for all these.

The ReaMe.txt file in the EasyTracker library defines these.  I've removed the
ones were the same as the default values.

http://codereview.appspot.com/5443046/diff/1/NotePad/res/values/GoogleAnalyti...
NotePad/res/values/GoogleAnalytics.xml:9: <integer
name="ga_dispatchPeriod">5</integer>
On 2011/11/28 17:37:08, nrhodes wrote:
> 5 seems *very* small.

Changed to 30.

http://codereview.appspot.com/5443046/diff/1/NotePad/res/values/GoogleAnalyti...
NotePad/res/values/GoogleAnalytics.xml:11: <string
name="com.example.android.notepad.NoteEditor">NoteEditor</string>
On 2011/11/28 17:37:08, nrhodes wrote:
> Add comment that we're mapping the class name to the reported name.

Done.

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
File NotePad/src/com/example/android/notepad/NoteEditor.java (right):

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
NotePad/src/com/example/android/notepad/NoteEditor.java:19: import
com.google.android.apps.analytics.easytracking.TrackedActivity;
On 2011/11/28 17:37:08, nrhodes wrote:
> put *after* com.example...
> (so it's in alphabetical order).

Done.

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
NotePad/src/com/example/android/notepad/NoteEditor.java:110: public void
onCreate(Bundle savedInstanceState) {
On 2011/11/28 17:37:08, nrhodes wrote:
> Once you fix TrackedActivity, you can leave this protected.

Done.

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
File NotePad/src/com/example/android/notepad/NotesList.java (right):

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
NotePad/src/com/example/android/notepad/NotesList.java:19: import
com.google.android.apps.analytics.easytracking.TrackedListActivity;
On 2011/11/28 17:37:08, nrhodes wrote:
> re-order.

Done.

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
NotePad/src/com/example/android/notepad/NotesList.java:63: public void
onCreate(Bundle savedInstanceState) {
On 2011/11/28 17:37:08, nrhodes wrote:
> leave as protected

Done.

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
File NotePad/src/com/example/android/notepad/TitleEditor.java (right):

http://codereview.appspot.com/5443046/diff/1/NotePad/src/com/example/android/...
NotePad/src/com/example/android/notepad/TitleEditor.java:19: import
com.google.android.apps.analytics.easytracking.TrackedActivity;
On 2011/11/28 17:37:08, nrhodes wrote:
> reorder.

Done.

[nrhodes, 2011-11-28 17:52:05]

LGTM, but please submit change to fix TrackedActivity public/protected first.