Adding compile fixes (exceptions & kill function).

Adding compile fixes (exceptions & kill function).

TimeoutException was being masked by the default implementation.
SocketException was not compiling, so I copied the class from
dart:io. kill function also wasn't compiling so I've wrapped it
with killNative => true.

A few more log messages are printed also.

R=tapted@chromium.org

Committed: https://github.com/tapted/bleeding_edge/commit/0fb9503

[tapted, 2014-01-20 06:24:26]

https://codereview.appspot.com/54400043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.appspot.com/54400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/io.dart:485: bool kill(signal) =>
killNative(signal);
To wrap it this way, you would want to pass _process `killNative` as well. But!
I think we should just mock out dart:io Process with stubs in io_wrap.dart,
otherwise you might start poking into extra bits that don't compile (simiar to
SocketException)

https://codereview.appspot.com/54400043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart (right):

https://codereview.appspot.com/54400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart:289: class SocketException
{
shouldn't it it still extend Exception?

[pajamallama, 2014-01-21 05:58:38]

Made those changes.

https://codereview.appspot.com/54400043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.appspot.com/54400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/io.dart:485: bool kill(signal) =>
killNative(signal);
On 2014/01/20 06:24:26, tapted wrote:
> To wrap it this way, you would want to pass _process `killNative` as well.
But!
> I think we should just mock out dart:io Process with stubs in io_wrap.dart,
> otherwise you might start poking into extra bits that don't compile (simiar to
> SocketException)

Done.

https://codereview.appspot.com/54400043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart (right):

https://codereview.appspot.com/54400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart:289: class SocketException
{
On 2014/01/20 06:24:26, tapted wrote:
> shouldn't it it still extend Exception?

Done.

[tapted, 2014-01-22 00:28:39]

https://codereview.appspot.com/54400043/diff/40001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart (right):

https://codereview.appspot.com/54400043/diff/40001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart:294: const
SocketException(this.message, {this.osError, this.address, this.port});
Since (apart from [IO]Exception) this is otherwise identical to
dart/sdk/lib/io/socket.dart, can we use the constructor verbatim. I.e.

  const SocketException(String this.message,
                        {OSError this.osError,
                         InternetAddress this.address,
                         int this.port});

https://codereview.appspot.com/54400043/diff/40001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart:351: class PubProcess {
Oops - sorry I wasn't clear. I meant: keep this in pub/lib/src/io.dart but,
here, mock out dart:io Process, mirrored from sdk/lib/io/process.dart, with
functions replaced by stubs that either make sense or no-op when running in a
browser.

You can leave it abstract, and have pretty much a verbatim copy of the interface
from sdk/lib/io/process.dart to provide something for dart2js, i.e.

abstract class Process {
  /* fields, etc. */
  bool kill([ProcessSignal signal = ProcessSignal.SIGTERM]);
}

then (if you need to actually create one)

class DummyProcess implements Process {
  bool kill([ProcessSignal signal = ProcessSignal.SIGTERM]) => true;
  /* etc */
}


The goal is to minimise the diff in dart/sdk/lib/_internal/pub/lib/src/io.dart
by giving dart2js dummy copies of VM-things that it doesn't get access to.

[pajamallama, 2014-01-22 02:21:26]

https://codereview.appspot.com/54400043/diff/40001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart (right):

https://codereview.appspot.com/54400043/diff/40001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart:294: const
SocketException(this.message, {this.osError, this.address, this.port});
On 2014/01/22 00:28:40, tapted wrote:
> Since (apart from [IO]Exception) this is otherwise identical to
> dart/sdk/lib/io/socket.dart, can we use the constructor verbatim. I.e.
> 
>   const SocketException(String this.message,
>                         {OSError this.osError,
>                          InternetAddress this.address,
>                          int this.port});

Done (aka N/A).

https://codereview.appspot.com/54400043/diff/40001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart:351: class PubProcess {
On 2014/01/22 00:28:40, tapted wrote:
> Oops - sorry I wasn't clear. I meant: keep this in pub/lib/src/io.dart but,
> here, mock out dart:io Process, mirrored from sdk/lib/io/process.dart, with
> functions replaced by stubs that either make sense or no-op when running in a
> browser.
> 
> You can leave it abstract, and have pretty much a verbatim copy of the
interface
> from sdk/lib/io/process.dart to provide something for dart2js, i.e.
> 
> abstract class Process {
>   /* fields, etc. */
>   bool kill([ProcessSignal signal = ProcessSignal.SIGTERM]);
> }
> 
> then (if you need to actually create one)
> 
> class DummyProcess implements Process {
>   bool kill([ProcessSignal signal = ProcessSignal.SIGTERM]) => true;
>   /* etc */
> }
> 
> 
> The goal is to minimise the diff in dart/sdk/lib/_internal/pub/lib/src/io.dart
> by giving dart2js dummy copies of VM-things that it doesn't get access to.

Done.

[tapted, 2014-01-22 02:29:11]

sweet - lgtm with a nit

https://codereview.appspot.com/54400043/diff/60001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.appspot.com/54400043/diff/60001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/lib/src/io.dart:486: _process.kill(signal);
nit: remove 2 spaces of indent

[pajamallama, 2014-01-22 03:41:06]

Committed patchset #6 manually as r0fb9503 (presubmit successful).