Adding a library interface to tavern (so it looks like a package).

Adding a library interface to tavern (so it looks like a package).

lib/src/app/tavern.dart exposes the major functionality of tavern
as a package.

The dependency on the package chrome_gen has been updated to use chrome
as the former is being deprecated.

R=tapted@chromium.org

Committed: https://github.com/tapted/bleeding_edge/commit/d555ad4

[tapted, 2014-01-20 06:33:36]

https://codereview.appspot.com/54380043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/app/tavern.dart (right):

https://codereview.appspot.com/54380043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/app/tavern.dart:1: // Copyright (c) 2013, the
Dart project authors.  Please see the AUTHORS file
nit: It's 2014 :p

https://codereview.appspot.com/54380043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart (right):

https://codereview.appspot.com/54380043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart:20: static Directory
workingDir;
It's pretty uncommon to make a public data member like this, which others set.
Maybe add a setter?

[tapted, 2014-01-21 01:59:17]

lgtm if you're just deleting lines in an upate

https://codereview.appspot.com/54380043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart (right):

https://codereview.appspot.com/54380043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart:20: static Directory
workingDir;
On 2014/01/20 06:33:36, tapted wrote:
> It's pretty uncommon to make a public data member like this, which others set.
> Maybe add a setter?

Actually Dart says: "Don't do this", so ignore me :p
https://www.dartlang.org/articles/style-guide/#avoid-wrapping-fields-in-gette...

[pajamallama, 2014-01-21 02:05:14]

https://codereview.appspot.com/54380043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/app/tavern.dart (right):

https://codereview.appspot.com/54380043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/app/tavern.dart:1: // Copyright (c) 2013, the
Dart project authors.  Please see the AUTHORS file
On 2014/01/20 06:33:36, tapted wrote:
> nit: It's 2014 :p

Done.

[pajamallama, 2014-01-21 02:05:45]

Committed patchset #4 manually as rd555ad4 (presubmit successful).