Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1516)

Issue 5437128: Cleanup in ASan interceptors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by samsonov
Modified:
7 years, 9 months ago
Reviewers:
ramosian.glider, kcc
CC:
llvm-commits_cs.uiuc.edu
Base URL:
http://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/asan/
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Cleanup in ASan interceptors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -27 lines) Patch
M Makefile.old View 1 1 chunk +1 line, -1 line 0 comments Download
M asan_interceptors.cc View 1 12 chunks +23 lines, -26 lines 0 comments Download

Messages

Total messages: 5
kcc
[off-topic: is llvm-commits interested in asan-rt-specific code reviews?] http://codereview.appspot.com/5437128/diff/1/Makefile.old File Makefile.old (right): http://codereview.appspot.com/5437128/diff/1/Makefile.old#newcode162 Makefile.old:162: ASAN_LD_TAIL=$(LIBASAN_A) ...
7 years, 9 months ago (2011-12-04 01:20:31 UTC) #1
samsonov
http://codereview.appspot.com/5437128/diff/1/Makefile.old File Makefile.old (right): http://codereview.appspot.com/5437128/diff/1/Makefile.old#newcode162 Makefile.old:162: ASAN_LD_TAIL=$(LIBASAN_A) On 2011/12/04 01:20:31, kcc wrote: > We should ...
7 years, 9 months ago (2011-12-05 11:11:44 UTC) #2
kcc
> Hm-m, let it be a temporary fix then. Without this change, changes in asan ...
7 years, 9 months ago (2011-12-05 19:00:55 UTC) #3
ramosian.glider
Just do `make clean; make tests` There are many implicit deps for the tests, including ...
7 years, 9 months ago (2011-12-06 08:43:58 UTC) #4
samsonov
7 years, 9 months ago (2011-12-06 09:01:09 UTC) #5
On 2011/12/06 08:43:58, ramosian.glider wrote:
> Just do `make clean; make tests`
Sure I did, this doesn't work.

> There are many implicit deps for the tests, including a dependency on Clang
> itself. It's not a good idea to hard-code them all.

OK, disregard the change to Makefile then.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b