Issue 5436047: quick start sample for user provisioning
|
Created:
12 years, 5 months ago by shraddhag Modified:
12 years, 4 months ago CC:
gdata-python-client-library-contributors_googlegroups.com Visibility:
Public. |
Patch Set 1 #
Total comments: 22
Patch Set 2 : Addressed the comments #
Total comments: 2
MessagesTotal messages: 6
http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... File samples/apps/userprovisioning_quick_start_example.py (right): http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:20: $ python userprovisining_quick_start_Example.py s/userprovisining/userprovisioning http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:20: $ python userprovisining_quick_start_Example.py why the capital E in Example? http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:22: You can also give user credentials as the command-line s/You can also give user credentials as the command-line/You can also specify the user credentials from the command-line http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:24: $ python groupsettings.py --client_id [client_id] groupsettings? http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:56: token = gdata.gauth.OAuth2Token( Don't put this code in the object constructor, expose another method to perform authorization. This will also allow other developers to replace the OAuth 2.0 command-line flow with the flow of their choice. http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:75: does lint like this empty line? I'm pretty sure there should be no empty line here http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:104: user_name = given_name = family_name = password = None do you need this line? Even without it, those variables will be None http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:138: print response why don't you use the _PrintUserDetails method you defined? http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:244: """Runs the sample by getting user input and takin appropriate action.""" s/takin/taking http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:246: #List of all the function and there description space after # http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:246: #List of all the function and there description s/List of all the function and there description/List of all the functions and their descriptions
Sign in to reply to this message.
http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... File samples/apps/userprovisioning_quick_start_example.py (right): http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:20: $ python userprovisining_quick_start_Example.py On 2011/11/25 21:15:40, Claudio Cherubino wrote: > s/userprovisining/userprovisioning Done. http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:20: $ python userprovisining_quick_start_Example.py On 2011/11/25 21:15:40, Claudio Cherubino wrote: > why the capital E in Example? Done. http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:22: You can also give user credentials as the command-line On 2011/11/25 21:15:40, Claudio Cherubino wrote: > s/You can also give user credentials as the command-line/You can also specify > the user credentials from the command-line Done. http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:24: $ python groupsettings.py --client_id [client_id] On 2011/11/25 21:15:40, Claudio Cherubino wrote: > groupsettings? Done. http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:56: token = gdata.gauth.OAuth2Token( On 2011/11/25 21:15:40, Claudio Cherubino wrote: > Don't put this code in the object constructor, expose another method to perform > authorization. This will also allow other developers to replace the OAuth 2.0 > command-line flow with the flow of their choice. Done. http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:75: On 2011/11/25 21:15:40, Claudio Cherubino wrote: > does lint like this empty line? I'm pretty sure there should be no empty line > here Done. http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:104: user_name = given_name = family_name = password = None it does not allow me to check 'while not user_name:' until variable has been referred once, as it does not exist for checking > http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:138: print response On 2011/11/25 21:15:40, Claudio Cherubino wrote: > why don't you use the _PrintUserDetails method you defined? Done. http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:244: """Runs the sample by getting user input and takin appropriate action.""" On 2011/11/25 21:15:40, Claudio Cherubino wrote: > s/takin/taking Done. http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:246: #List of all the function and there description On 2011/11/25 21:15:40, Claudio Cherubino wrote: > space after # Done. http://codereview.appspot.com/5436047/diff/1/samples/apps/userprovisioning_qu... samples/apps/userprovisioning_quick_start_example.py:246: #List of all the function and there description On 2011/11/25 21:15:40, Claudio Cherubino wrote: > s/List of all the function and there description/List of all the functions and > their descriptions Done.
Sign in to reply to this message.
LGTM
Sign in to reply to this message.
http://codereview.appspot.com/5436047/diff/1003/samples/apps/userprovisioning... File samples/apps/userprovisioning_quick_start_example.py (right): http://codereview.appspot.com/5436047/diff/1003/samples/apps/userprovisioning... samples/apps/userprovisioning_quick_start_example.py:95: def _GetChoice(self, for_value): Description for function and @parameters http://codereview.appspot.com/5436047/diff/1003/samples/apps/userprovisioning... samples/apps/userprovisioning_quick_start_example.py:155: attr = int(raw_input('\nEnter number(1-5) of attribute to be updated ')) What if more than one fields need to be updated
Sign in to reply to this message.
|
