Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(320)

Issue 54360043: code review 54360043: archive/zip: new zip using utf8 filename. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by chai2010
Modified:
8 years ago
Visibility:
Public.

Description

archive/zip: new zip using utf8 filename as default.

Patch Set 1 #

Patch Set 2 : diff -r 2df447356d7f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2df447356d7f https://code.google.com/p/go/ #

Patch Set 4 : diff -r 2df447356d7f https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/pkg/archive/zip/writer.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
chai2010
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
8 years, 8 months ago (2014-01-20 01:53:07 UTC) #1
bradfitz
What if the filename isn't UTF-8? We never enforced that. Why unconditionally advertise/promise that? On ...
8 years, 8 months ago (2014-01-20 06:49:32 UTC) #2
chai2010
If the filename contains chinese charactors, the local zip tools (7z/winrar) will decode the filename ...
8 years, 8 months ago (2014-01-20 08:11:10 UTC) #3
gobot
R=adg@golang.org (assigned by bradfitz@golang.org)
8 years, 8 months ago (2014-01-22 00:12:29 UTC) #4
adg
A Go string is not necessarily utf-8. See: http://blog.golang.org/strings I don't think we can make ...
8 years, 8 months ago (2014-01-28 03:26:46 UTC) #5
dfc
8 years, 8 months ago (2014-01-31 00:03:46 UTC) #6
On 2014/01/28 03:26:46, adg wrote:
> A Go string is not necessarily utf-8. See: http://blog.golang.org/strings
> 
> I don't think we can make this change anyway, because of the compatibility
> promise. Who knows what code this might break.

not lgtm.

Please start by raising an issue, golang.org/issue/new, laying out the problem.

R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b