Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 5434061: do not tinker with the position of a pitched rest (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by benko.pal
Modified:
5 years, 10 months ago
Reviewers:
Graham Percival, email
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

do not tinker with the position of a pitched rest

Patch Set 1 #

Patch Set 2 : rebase to 49fbcc8b526edcad8a0650e9d7870b647c43d698 #

Patch Set 3 : fix default rest position in nonstandard staves #

Patch Set 4 : rests within staff lines have ledger lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -57 lines) Patch
M input/regression/rest-on-nonstandard-staff.ly View 1 2 1 chunk +32 lines, -12 lines 0 comments Download
M lily/include/staff-symbol.hh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M lily/rest.cc View 1 2 3 7 chunks +40 lines, -28 lines 0 comments Download
M lily/staff-symbol.cc View 1 2 3 5 chunks +30 lines, -15 lines 0 comments Download
M lily/staff-symbol-referencer.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
benko.pal
hi all, if I extend the staff by a line, pitched rests appear shifted by ...
6 years, 2 months ago (2011-11-23 22:12:52 UTC) #1
benko.pal
patch rebased
6 years, 2 months ago (2011-12-19 20:41:36 UTC) #2
Graham Percival
On Mon, Dec 19, 2011 at 08:41:36PM +0000, benko.pal@gmail.com wrote: > patch rebased > > ...
6 years, 2 months ago (2011-12-20 15:46:27 UTC) #3
benko.pal
hi Graham, 2011/12/20 Graham Percival <graham@percival-music.ca>: > On Mon, Dec 19, 2011 at 08:41:36PM +0000, ...
6 years, 2 months ago (2011-12-21 10:34:19 UTC) #4
email_philholmes.net
----- Original Message ----- From: "Benko Pál" <benko.pal@gmail.com> To: "Graham Percival" <graham@percival-music.ca> Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>; ...
6 years, 2 months ago (2011-12-21 10:42:24 UTC) #5
benko.pal
6 years, 2 months ago (2011-12-21 10:52:23 UTC) #6
>>>> patch rebased
>>>>
>>>> http://codereview.appspot.com/5434061/
>>>
>>> Unless you use the new git-cl to upload it, nobody will notice
>>> that you have updated your patch.
>>> manually change it from Patch-needs_work to Patch-new.

> Added to the tracker as a committer.

thanks, Phil; label updated.
p
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d