Issue 5434056: Add EasyTrackerTest.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by jjc

Modified:
9 months ago

Reviewers:
nrhodes, tanyajackson638

CC:
analytics-api-samples-discuss_googlegroups.com

Base URL:
http://analytics-api-samples.googlecode.com/svn/trunk/src/tracking/mobile/android/

Visibility:
Public.

More Reviews

Patch Set 2 : Moved Test project. #

Patch Set 3 : Move to the right spot. #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+796 lines, -0 lines)			Patch
A	Test/AndroidManifest.xml	View	1 2	1 chunk	+19 lines, -0 lines	0 comments	Download
A	Test/COPYING	View	1 2	1 chunk	+202 lines, -0 lines	0 comments	Download
A	Test/ReadMe.txt	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
A	Test/project.properties	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
A	Test/res/drawable-hdpi/ic_launcher.png	View	1 2	Binary file		0 comments	Download
A	Test/res/drawable-ldpi/ic_launcher.png	View	1 2	Binary file		0 comments	Download
A	Test/res/drawable-mdpi/ic_launcher.png	View	1 2	Binary file		0 comments	Download
A	Test/res/layout/main.xml	View	1 2	1 chunk	+26 lines, -0 lines	0 comments	Download
A	Test/res/values/strings.xml	View	1 2	1 chunk	+32 lines, -0 lines	0 comments	Download
A	Test/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java	View	1 2	1 chunk	+186 lines, -0 lines	0 comments	Download
A	Test/src/com/google/android/apps/analytics/easytracking/MockGoogleAnalyticsTracker.java	View	1 2	1 chunk	+187 lines, -0 lines	0 comments	Download
A	Test/src/com/google/android/apps/analytics/easytracking/MockParameterLoader.java	View	1 2	1 chunk	+66 lines, -0 lines	0 comments	Download
A	Test/src/com/google/android/apps/analytics/easytracking/ParameterLoaderImplTest.java	View	1 2	1 chunk	+61 lines, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

nrhodes

http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/AndroidManifest.xml File EasyTrackerTest/AndroidManifest.xml (right): http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/AndroidManifest.xml#newcode1 EasyTrackerTest/AndroidManifest.xml:1: <?xml version="1.0" encoding="utf-8"?> I think all these files should ...

11 years, 10 months ago (2011-11-23 21:09:48 UTC) #2

jjc

11 years, 10 months ago (2011-11-23 21:33:20 UTC) #4

nrhodes

LGTM http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java File EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java (right): http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java#newcode15 EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15: package com.google.android.apps.analytics.easytracking; On 2011/11/23 21:33:20, jjc wrote: > ...

11 years, 10 months ago (2011-11-23 21:49:42 UTC) #6

tanyajackson638

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/values/strings.xml File EasyTrackerTest/res/values/strings.xml (right): https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/values/strings.xml#newcode1 EasyTrackerTest/res/values/strings.xml:1: <?xml version="1.0" encoding="utf-8"?> On 2011/11/23 21:09:48, nrhodes wrote: > ...

9 months ago (2022-12-26 15:11:33 UTC) #7

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/values/stri...
File EasyTrackerTest/res/values/strings.xml (right):

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/values/stri...
EasyTrackerTest/res/values/strings.xml:1: <?xml version="1.0" encoding="utf-8"?>
On 2011/11/23 21:09:48, nrhodes wrote:
> copyright and license.

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/values/stri...
EasyTrackerTest/res/values/strings.xml:1: <?xml version="1.0" encoding="utf-8"?>
On 2011/11/23 21:33:20, jjc wrote:
> On 2011/11/23 21:09:48, nrhodes wrote:
> > copyright and license.
> 
> Done.

Done.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/values/stri...
EasyTrackerTest/res/values/strings.xml:1: <?xml version="1.0" encoding="utf-8"?>
On 2011/11/23 21:33:20, jjc wrote:
> On 2011/11/23 21:09:48, nrhodes wrote:
> > copyright and license.
> 
> Done.

Done.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/values/stri...
EasyTrackerTest/res/values/strings.xml:1: <?xml version="1.0" encoding="utf-8"?>
On 2011/11/23 21:09:48, nrhodes wrote:
> copyright and license.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/values/stri...
EasyTrackerTest/res/values/strings.xml:1: <?xml version="1.0" encoding="utf-8"?>
On 2011/11/23 21:09:48, nrhodes wrote:
> copyright and license.

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/values/stri...
EasyTrackerTest/res/values/strings.xml:1: <?xml version="1.0" encoding="utf-8"?>
On 2011/11/23 21:09:48, nrhodes wrote:
> copyright and license.

Done.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/values/stri...
EasyTrackerTest/res/values/strings.xml:1: <?xml version="1.0" encoding="utf-8"?>
On 2011/11/23 21:09:48, nrhodes wrote:
> copyright and license.

Done.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
File
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java
(right):

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:09:48, nrhodes wrote:
> package should be analytics.easytracking.samples?

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:09:48, nrhodes wrote:
> package should be analytics.easytracking.samples?

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:49:43, nrhodes wrote:
> On 2011/11/23 21:33:20, jjc wrote:
> > On 2011/11/23 21:09:48, nrhodes wrote:
> > > package should be analytics.easytracking.samples?
> > 
> > If I don't use the same package as the EasyTracker, I have to make test
> methods
> > public there.
> 
> Fair enough.

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:33:20, jjc wrote:
> On 2011/11/23 21:09:48, nrhodes wrote:
> > package should be analytics.easytracking.samples?
> 
> If I don't use the same package as the EasyTracker, I have to make test
methods
> public there.

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:33:20, jjc wrote:
> On 2011/11/23 21:09:48, nrhodes wrote:
> > package should be analytics.easytracking.samples?
> 
> If I don't use the same package as the EasyTracker, I have to make test
methods
> public there.

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:09:48, nrhodes wrote:
> package should be analytics.easytracking.samples?

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:09:48, nrhodes wrote:
> package should be analytics.easytracking.samples?

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:09:48, nrhodes wrote:
> package should be analytics.easytracking.samples?

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:09:48, nrhodes wrote:
> package should be analytics.easytracking.samples?

Done.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:09:48, nrhodes wrote:
> package should be analytics.easytracking.samples?

Acknowledged.
2022/12/26 14:46:54

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:49:43, nrhodes wrote:
> On 2011/11/23 21:33:20, jjc wrote:
> > On 2011/11/23 21:09:48, nrhodes wrote:
> > > package should be analytics.easytracking.samples?
> > 
> > If I don't use the same package as the EasyTracker, I have to make test
> methods
> > public there.
> 
> Fair enough.

Acknowledged.
2022/12/26 14:44:32

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:33:20, jjc wrote:
> On 2011/11/23 21:09:48, nrhodes wrote:
> > package should be analytics.easytracking.samples?
> 
> If I don't use the same package as the EasyTracker, I have to make test
methods
> public there.
2022/12/26 14:42:36
Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:09:48, nrhodes wrote:
> package should be analytics.easytracking.samples?

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:33:20, jjc wrote:
> On 2011/11/23 21:09:48, nrhodes wrote:
> > package should be analytics.easytracking.samples?
> 
> If I don't use the same package as the EasyTracker, I have to make test
methods
> public there.

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:49:43, nrhodes wrote:
> On 2011/11/23 21:33:20, jjc wrote:
> > On 2011/11/23 21:09:48, nrhodes wrote:
> > > package should be analytics.easytracking.samples?
> > 
> > If I don't use the same package as the EasyTracker, I have to make test
> methods
> > public there.
> 
> Fair enough.

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:33:20, jjc wrote:
> On 2011/11/23 21:09:48, nrhodes wrote:
> > package should be analytics.easytracking.samples?
> 
> If I don't use the same package as the EasyTracker, I have to make test
methods
> public there.

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:49:43, nrhodes wrote:
> On 2011/11/23 21:33:20, jjc wrote:
> > On 2011/11/23 21:09:48, nrhodes wrote:
> > > package should be analytics.easytracking.samples?
> > 
> > If I don't use the same package as the EasyTracker, I have to make test
> methods
> > public there.
> 
> Fair enough.

Done.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:49:43, nrhodes wrote:
> On 2011/11/23 21:33:20, jjc wrote:
> > On 2011/11/23 21:09:48, nrhodes wrote:
> > > package should be analytics.easytracking.samples?
> > 
> > If I don't use the same package as the EasyTracker, I have to make test
> methods
> > public there.
> 
> Fair enough.

Done.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:09:48, nrhodes wrote:
> package should be analytics.easytracking.samples?

Done.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:09:48, nrhodes wrote:
> package should be analytics.easytracking.samples?

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:33:20, jjc wrote:
> On 2011/11/23 21:09:48, nrhodes wrote:
> > package should be analytics.easytracking.samples?
> 
> If I don't use the same package as the EasyTracker, I have to make test
methods
> public there.

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:33:20, jjc wrote:
> On 2011/11/23 21:09:48, nrhodes wrote:
> > package should be analytics.easytracking.samples?
> 
> If I don't use the same package as the EasyTracker, I have to make test
methods
> public there.

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:09:48, nrhodes wrote:
> package should be analytics.easytracking.samples?

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:09:48, nrhodes wrote:
> package should be analytics.easytracking.samples?

Acknowledged.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:49:43, nrhodes wrote:
> On 2011/11/23 21:33:20, jjc wrote:
> > On 2011/11/23 21:09:48, nrhodes wrote:
> > > package should be analytics.easytracking.samples?
> > 
> > If I don't use the same package as the EasyTracker, I have to make test
> methods
> > public there.
> 
> Fair enough.

https://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:33:20, jjc wrote:
> On 2011/11/23 21:09:48, nrhodes wrote:
> > package should be analytics.easytracking.samples?
> 
> If I don't use the same package as the EasyTracker, I have to make test
methods
> public there.

Done.

tanyajackson638

9 months ago (2022-12-26 15:20:48 UTC) #8

On 2011/11/23 21:09:48, nrhodes wrote:
>
http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/AndroidManifest.xml
> File EasyTrackerTest/AndroidManifest.xml (right):
> 
>
http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/AndroidManifest....
> EasyTrackerTest/AndroidManifest.xml:1: <?xml version="1.0" encoding="utf-8"?>
> I think all these files should be in mobile/android/easytracking/samples,
> assuming that'll work well with eclipse.
> 
>
http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/layout/main.xml
> File EasyTrackerTest/res/layout/main.xml (right):
> 
>
http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/layout/main....
> EasyTrackerTest/res/layout/main.xml:1: <?xml version="1.0" encoding="utf-8"?>
> go ahead and add copyright and license.
> 
>
http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/values/strin...
> File EasyTrackerTest/res/values/strings.xml (right):
> 
>
http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/res/values/strin...
> EasyTrackerTest/res/values/strings.xml:1: <?xml version="1.0"
encoding="utf-8"?>
> copyright and license.
> 
>
http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/a...
> File
>
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java
> (right):
> 
>
http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/a...
>
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
> package com.google.android.apps.analytics.easytracking;
> package should be analytics.easytracking.samples?

Expand All Messages | Collapse All Messages