Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(833)

Issue 5434056: Add EasyTrackerTest.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by jjc
Modified:
1 month, 2 weeks ago
Reviewers:
nrhodes
CC:
analytics-api-samples-discuss_googlegroups.com
Base URL:
http://analytics-api-samples.googlecode.com/svn/trunk/src/tracking/mobile/android/
Visibility:
Public.

Patch Set 1 #

Total comments: 9

Patch Set 2 : Moved Test project. #

Patch Set 3 : Move to the right spot. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+796 lines, -0 lines) Patch
A Test/AndroidManifest.xml View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A Test/COPYING View 1 2 1 chunk +202 lines, -0 lines 0 comments Download
A Test/ReadMe.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A Test/project.properties View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A Test/res/drawable-hdpi/ic_launcher.png View 1 2 Binary file 0 comments Download
A Test/res/drawable-ldpi/ic_launcher.png View 1 2 Binary file 0 comments Download
A Test/res/drawable-mdpi/ic_launcher.png View 1 2 Binary file 0 comments Download
A Test/res/layout/main.xml View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A Test/res/values/strings.xml View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A Test/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java View 1 2 1 chunk +186 lines, -0 lines 0 comments Download
A Test/src/com/google/android/apps/analytics/easytracking/MockGoogleAnalyticsTracker.java View 1 2 1 chunk +187 lines, -0 lines 0 comments Download
A Test/src/com/google/android/apps/analytics/easytracking/MockParameterLoader.java View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A Test/src/com/google/android/apps/analytics/easytracking/ParameterLoaderImplTest.java View 1 2 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 6
jjc
10 years, 5 months ago (2011-11-23 19:50:09 UTC) #1
nrhodes
http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/AndroidManifest.xml File EasyTrackerTest/AndroidManifest.xml (right): http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/AndroidManifest.xml#newcode1 EasyTrackerTest/AndroidManifest.xml:1: <?xml version="1.0" encoding="utf-8"?> I think all these files should ...
10 years, 5 months ago (2011-11-23 21:09:48 UTC) #2
jjc
10 years, 5 months ago (2011-11-23 21:33:17 UTC) #3
jjc
http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/AndroidManifest.xml File EasyTrackerTest/AndroidManifest.xml (right): http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/AndroidManifest.xml#newcode1 EasyTrackerTest/AndroidManifest.xml:1: <?xml version="1.0" encoding="utf-8"?> On 2011/11/23 21:09:48, nrhodes wrote: > ...
10 years, 5 months ago (2011-11-23 21:33:20 UTC) #4
jjc
10 years, 5 months ago (2011-11-23 21:34:23 UTC) #5
nrhodes
10 years, 5 months ago (2011-11-23 21:49:42 UTC) #6
LGTM

http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/a...
File
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java
(right):

http://codereview.appspot.com/5434056/diff/1/EasyTrackerTest/src/com/google/a...
EasyTrackerTest/src/com/google/android/apps/analytics/easytracking/EasyTrackerTest.java:15:
package com.google.android.apps.analytics.easytracking;
On 2011/11/23 21:33:20, jjc wrote:
> On 2011/11/23 21:09:48, nrhodes wrote:
> > package should be analytics.easytracking.samples?
> 
> If I don't use the same package as the EasyTracker, I have to make test
methods
> public there.

Fair enough.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b