Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1257)

Issue 54330043: Adding search functionality. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by pajamallama
Modified:
10 years, 3 months ago
Reviewers:
tapted
CC:
chrome-apps-internsyd_google.com
Base URL:
https://github.com/tapted/bleeding_edge.git@icon_change
Visibility:
Public.

Description

Adding search functionality. Now when the app loads then ${server}/api/packages is loaded and the packages field is listed to log output. Handles errors (tested). Also removed stray '/' at the end of the default url. Added another color to CSS for log output for the level 'message'. R=tapted@chromium.org Committed: https://github.com/tapted/bleeding_edge/commit/0788064

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixing nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M dart/sdk/lib/_internal/pub/lib/src/app/pubchrome.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/pub/lib/src/source/hosted.dart View 1 2 chunks +16 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/pub/style.css View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 3
pajamallama
10 years, 3 months ago (2014-01-19 22:57:54 UTC) #1
tapted
lgtm with nits https://codereview.appspot.com/54330043/diff/1/dart/sdk/lib/_internal/pub/lib/src/source/hosted.dart File dart/sdk/lib/_internal/pub/lib/src/source/hosted.dart (right): https://codereview.appspot.com/54330043/diff/1/dart/sdk/lib/_internal/pub/lib/src/source/hosted.dart#newcode64 dart/sdk/lib/_internal/pub/lib/src/source/hosted.dart:64: }).catchError((e) => log.error("Cannot load package list.")); ...
10 years, 3 months ago (2014-01-19 23:24:31 UTC) #2
pajamallama
10 years, 3 months ago (2014-01-20 00:50:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r0788064 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b