Issue 5432068: goyaml: omit zero-value pointers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5432068: goyaml: omit zero-value pointers

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by rog

Modified:
12 years, 5 months ago

Reviewers:
mp+83340

Visibility:
Public.

Description

The documentation does not explicitly mention pointers when marshalling, but it seems within the spirit of the documentation that nil pointers should not be marshalled when the omitzero tag is set. This enables struct values to be omitted from the output if desired. https://code.launchpad.net/~rogpeppe/goyaml/goyaml-omit-zero-pointers/+merge/83340 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -31 lines)			Patch
M	decode.go	View	5 chunks	+3 lines, -5 lines	0 comments	Download
M	decode_test.go	View	4 chunks	+4 lines, -7 lines	0 comments	Download
M	encode.go	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	encode_test.go	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	goyaml.go	View	8 chunks	+10 lines, -9 lines	0 comments	Download
M	resolve.go	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	suite_test.go	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

Please update the proposal once goyaml-error-fixes is in.

12 years, 5 months ago (2011-11-28 11:39:31 UTC) #1

niemeyer

> Please update the proposal once goyaml-error-fixes is in. This is still pending.

12 years, 5 months ago (2011-12-05 23:25:44 UTC) #2

Expand All Messages | Collapse All Messages