Issue 54300048: Documentation update for NTLMv2 handling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54300048: Documentation update for NTLMv2 handling (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by Tanmay Vartak

Modified:
10 years, 2 months ago

Reviewers:
ejona

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

Documentation update for NTLMv2 handling

Patch Set 2 : with code review changes #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	src/overview.html	View	1	3 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

ejona

LGTM It could be uploaded as-is without major issue. https://codereview.appspot.com/54300048/diff/1/src/overview.html File src/overview.html (right): https://codereview.appspot.com/54300048/diff/1/src/overview.html#newcode23 src/overview.html:23: ...

10 years, 2 months ago (2014-02-06 23:44:22 UTC) #2

Tanmay Vartak

will do it by EOD On Mon, Feb 10, 2014 at 3:48 PM, <ejona@google.com> wrote: ...

10 years, 2 months ago (2014-02-10 23:51:32 UTC) #4

ejona

On 2014/02/10 23:51:32, Tanmay Vartak wrote: > will do it by EOD Sounds fine. I ...

10 years, 2 months ago (2014-02-10 23:53:05 UTC) #5

Tanmay Vartak

10 years, 2 months ago (2014-02-11 21:19:28 UTC) #8

I already committed my changes :). Uploaded patch for traceability.

Regards,
Tanmay


On Tue, Feb 11, 2014 at 1:17 PM, <ejona@google.com> wrote:

> LGTM
>
> https://codereview.appspot.com/54300048/
>

Expand All Messages | Collapse All Messages