Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4403)

Issue 54300045: Added latest changes but system_cache not working yet. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by pajamallama
Modified:
10 years, 2 months ago
Reviewers:
tapted
CC:
chrome-apps-internsyd_google.com
Base URL:
https://github.com/tapted/spark@master
Visibility:
Public.

Description

Added latest changes but system_cache not working yet. launch.dart: Make a check for running Chrome Apps, if a 'pubspec.yaml' file is selected then run tavern. manifest.json: Renamed app to "Spark (with tavern)", changed the version number to 0.3 (to match tavern), added permission to access tapted's server process and added HTML5 unlimited filesystem storage capacity. spark_polymer.html: Add the tavern JS to be able to send logging message to the tavern log window. R=tapted@chromium.org Committed: https://github.com/tapted/bleeding_edge/commit/8000792

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed comment #

Patch Set 3 : Removing short_name from manifest.json #

Patch Set 4 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M ide/app/lib/launch.dart View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M ide/app/manifest.json View 1 2 3 3 chunks +5 lines, -6 lines 0 comments Download
M ide/app/spark_polymer.html View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6
pajamallama
This is a start, need to finish this off.
10 years, 2 months ago (2014-02-06 04:53:34 UTC) #1
tapted
https://codereview.appspot.com/54300045/diff/1/ide/app/manifest.json File ide/app/manifest.json (right): https://codereview.appspot.com/54300045/diff/1/ide/app/manifest.json#newcode3 ide/app/manifest.json:3: "short_name": "Spark", nit: let's drop this - it will ...
10 years, 2 months ago (2014-02-06 05:11:00 UTC) #2
pajamallama
https://codereview.appspot.com/54300045/diff/1/ide/app/manifest.json File ide/app/manifest.json (right): https://codereview.appspot.com/54300045/diff/1/ide/app/manifest.json#newcode3 ide/app/manifest.json:3: "short_name": "Spark", On 2014/02/06 05:11:00, tapted wrote: > nit: ...
10 years, 2 months ago (2014-02-06 05:45:47 UTC) #3
tapted
lgtm after comments and "TODO: describe changes here." resolved https://codereview.appspot.com/54300045/diff/1/ide/app/manifest.json File ide/app/manifest.json (right): https://codereview.appspot.com/54300045/diff/1/ide/app/manifest.json#newcode3 ide/app/manifest.json:3: ...
10 years, 2 months ago (2014-02-06 06:11:38 UTC) #4
pajamallama
https://codereview.appspot.com/54300045/diff/1/ide/app/manifest.json File ide/app/manifest.json (right): https://codereview.appspot.com/54300045/diff/1/ide/app/manifest.json#newcode3 ide/app/manifest.json:3: "short_name": "Spark", On 2014/02/06 06:11:38, tapted wrote: > On ...
10 years, 2 months ago (2014-02-06 22:33:37 UTC) #5
pajamallama
10 years, 2 months ago (2014-02-06 22:50:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r8000792 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b