Issue 54220043: code review 54220043: runtime/race: race instrument reads/writes in select cases

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54220043: code review 54220043: runtime/race: race instrument reads/writes in select cases (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by dvyukov

Modified:
11 years, 1 month ago

Reviewers:
khr

CC:
khr, golang-codereviews

Visibility:
Public.

Description

runtime/race: race instrument reads/writes in select cases The new select tests currently fail (the race is not detected).

Patch Set 1 #

Patch Set 2 : diff -r 5b5a2d2d2563 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r d712f74d2e6b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r d712f74d2e6b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r d712f74d2e6b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 32309d9c952e https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -19 lines)			Patch
	M	src/pkg/runtime/chan.c	View	1 2	12 chunks	+36 lines, -19 lines	0 comments	Download
	M	src/pkg/runtime/race/testdata/chan_test.go	View	1 2 3	1 chunk	+113 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello khr@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 1 month ago (2014-01-21 08:48:39 UTC) #1

dvyukov

11 years, 1 month ago (2014-01-22 06:36:24 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=60a0c4c04f5f ***

runtime/race: race instrument reads/writes in select cases
The new select tests currently fail (the race is not detected).

R=khr
CC=golang-codereviews
https://codereview.appspot.com/54220043

Expand All Messages | Collapse All Messages