Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(154)

Issue 54210050: code review 54210050: include, linlink, cmd/6l, cmd/ld: part 1 of solaris/amd... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by minux1
Modified:
11 years, 4 months ago
Reviewers:
iant
CC:
golang-codereviews, iant, dave_cheney.net
Visibility:
Public.

Description

include, linlink, cmd/6l, cmd/ld: part 1 of solaris/amd64 linker changes. rsc suggested that we split the whole linker changes into three parts. This is the first one, mostly dealing with adding Hsolaris.

Patch Set 1 #

Patch Set 2 : diff -r ec5195954667 https://code.google.com/p/go #

Patch Set 3 : diff -r ec5195954667 https://code.google.com/p/go #

Patch Set 4 : diff -r 77ec90945d15 https://code.google.com/p/go #

Patch Set 5 : diff -r 77ec90945d15 https://code.google.com/p/go #

Patch Set 6 : diff -r 77ec90945d15 https://code.google.com/p/go #

Patch Set 7 : diff -r e4915357c9e8 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -13 lines) Patch
M include/link.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/5l/asm.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/6l/asm.c View 1 4 chunks +4 lines, -0 lines 0 comments Download
M src/cmd/6l/obj.c View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/cmd/8l/asm.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/ld/doc.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/ld/elf.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/ld/elf.c View 1 3 chunks +24 lines, -10 lines 0 comments Download
M src/cmd/ld/lib.c View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/liblink/obj6.c View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/liblink/sym.c View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
minux1
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2014-02-09 07:25:04 UTC) #1
iant
LGTM
11 years, 4 months ago (2014-02-09 20:24:05 UTC) #2
dave_cheney.net
Thanks Minux. On Mon, Feb 10, 2014 at 7:24 AM, <iant@golang.org> wrote: > LGTM > ...
11 years, 4 months ago (2014-02-09 21:19:06 UTC) #3
minux1
11 years, 4 months ago (2014-02-09 21:45:41 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=2f0757d362f5 ***

include, linlink, cmd/6l, cmd/ld: part 1 of solaris/amd64 linker changes.
rsc suggested that we split the whole linker changes into three parts.
This is the first one, mostly dealing with adding Hsolaris.

LGTM=iant
R=golang-codereviews, iant, dave
CC=golang-codereviews
https://codereview.appspot.com/54210050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b