Issue 5418043: Fix errors to print their string values.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5418043: Fix errors to print their string values.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by rog

Modified:
12 years, 4 months ago

Reviewers:
mp+82714

Visibility:
Public.

Description

Fix errors to print their string values. Also, fmt.Stringer is a more conventional interface type than hasString. https://code.launchpad.net/~rogpeppe/gocheck/fix-error-printing/+merge/82714 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
	M	checkers.go	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	gocheck.go	View		2 chunks	+14 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

niemeyer

12 years, 4 months ago (2011-12-13 21:11:32 UTC) #2

*** Submitted:

Fix errors to print their string values.

Also, fmt.Stringer is a more conventional interface
type than hasString.

R=
CC=
https://codereview.appspot.com/5418043

Expand All Messages | Collapse All Messages