Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(146)

Issue 5417048: IPv6 support for TCP/UDP in NS-3

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by kdrenard2
Modified:
10 years, 3 months ago
CC:
John Abraham, ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Patch against ns-3-dev (8-Jan-2012) with tests and address generator #

Patch Set 3 : Patch applies cleanly, documentation, address printing #

Total comments: 3

Patch Set 4 : Updates per suggestion from Tommaso Pecorella #

Total comments: 5

Patch Set 5 : Cleanup per comments from Tom Henderson (9 Feb 2012) #

Total comments: 1

Patch Set 6 : Uninitialized variable #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3471 lines, -701 lines) Patch
M CHANGES.html View 1 2 3 1 chunk +68 lines, -0 lines 0 comments Download
M examples/udp-client-server/udp-client-server.cc View 3 chunks +22 lines, -4 lines 0 comments Download
M examples/udp-client-server/udp-trace-client-server.cc View 3 chunks +22 lines, -4 lines 0 comments Download
M examples/udp/udp-echo.cc View 3 chunks +19 lines, -4 lines 0 comments Download
M src/applications/helper/udp-client-server-helper.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/applications/helper/udp-client-server-helper.cc View 2 chunks +32 lines, -2 lines 0 comments Download
M src/applications/helper/udp-echo-helper.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/applications/helper/udp-echo-helper.cc View 1 chunk +15 lines, -1 line 0 comments Download
M src/applications/model/packet-sink.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/applications/model/udp-client.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/applications/model/udp-client.cc View 1 2 3 5 chunks +43 lines, -9 lines 0 comments Download
M src/applications/model/udp-echo-client.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/applications/model/udp-echo-client.cc View 1 2 3 6 chunks +46 lines, -8 lines 0 comments Download
M src/applications/model/udp-echo-server.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/applications/model/udp-echo-server.cc View 5 chunks +42 lines, -1 line 0 comments Download
M src/applications/model/udp-server.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/applications/model/udp-server.cc View 3 chunks +32 lines, -7 lines 0 comments Download
M src/applications/model/udp-trace-client.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/applications/model/udp-trace-client.cc View 1 2 5 chunks +49 lines, -9 lines 0 comments Download
M src/csma-layout/examples/csma-star.cc View 1 8 chunks +74 lines, -16 lines 0 comments Download
M src/csma-layout/model/csma-star-helper.h View 1 5 chunks +26 lines, -0 lines 0 comments Download
M src/csma-layout/model/csma-star-helper.cc View 1 2 chunks +33 lines, -0 lines 0 comments Download
M src/internet/doc/internet-stack.rst View 1 2 3 3 chunks +15 lines, -4 lines 0 comments Download
M src/internet/doc/ipv6.rst View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/internet/model/icmpv4-l4-protocol.h View 4 chunks +14 lines, -8 lines 0 comments Download
M src/internet/model/icmpv4-l4-protocol.cc View 5 chunks +27 lines, -7 lines 0 comments Download
M src/internet/model/icmpv6-l4-protocol.h View 4 chunks +18 lines, -3 lines 0 comments Download
M src/internet/model/icmpv6-l4-protocol.cc View 1 8 chunks +36 lines, -6 lines 0 comments Download
A src/internet/model/ip-l4-protocol.h View 1 chunk +127 lines, -0 lines 0 comments Download
A src/internet/model/ip-l4-protocol.cc View 1 chunk +61 lines, -0 lines 0 comments Download
M src/internet/model/ipv4.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/internet/model/ipv4-l3-protocol.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/internet/model/ipv4-l3-protocol.cc View 1 5 chunks +10 lines, -11 lines 0 comments Download
R src/internet/model/ipv4-l4-protocol.h View 1 2 1 chunk +0 lines, -113 lines 0 comments Download
R src/internet/model/ipv4-l4-protocol.cc View 1 2 1 chunk +0 lines, -55 lines 0 comments Download
M src/internet/model/ipv4-raw-socket-impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/model/ipv4-raw-socket-impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/internet/model/ipv6-end-point.h View 4 chunks +7 lines, -5 lines 0 comments Download
M src/internet/model/ipv6-end-point.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/internet/model/ipv6-l3-protocol.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/internet/model/ipv6-l3-protocol.cc View 1 2 5 chunks +11 lines, -10 lines 0 comments Download
R src/internet/model/ipv6-l4-protocol.h View 1 2 1 chunk +0 lines, -109 lines 0 comments Download
R src/internet/model/ipv6-l4-protocol.cc View 1 2 1 chunk +0 lines, -53 lines 0 comments Download
M src/internet/model/ipv6-raw-socket-impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/model/ipv6-raw-socket-impl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/internet/model/nsc-tcp-l4-protocol.h View 1 4 chunks +14 lines, -8 lines 0 comments Download
M src/internet/model/nsc-tcp-l4-protocol.cc View 1 5 chunks +23 lines, -6 lines 0 comments Download
M src/internet/model/nsc-tcp-socket-impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/model/nsc-tcp-socket-impl.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M src/internet/model/tcp-header.h View 1 3 chunks +9 lines, -2 lines 0 comments Download
M src/internet/model/tcp-header.cc View 1 chunk +51 lines, -7 lines 0 comments Download
M src/internet/model/tcp-l4-protocol.h View 1 6 chunks +31 lines, -8 lines 0 comments Download
M src/internet/model/tcp-l4-protocol.cc View 1 11 chunks +289 lines, -22 lines 0 comments Download
M src/internet/model/tcp-socket-base.h View 1 4 chunks +6 lines, -0 lines 0 comments Download
M src/internet/model/tcp-socket-base.cc View 1 2 3 30 chunks +428 lines, -73 lines 0 comments Download
M src/internet/model/udp-header.h View 3 chunks +33 lines, -2 lines 0 comments Download
M src/internet/model/udp-header.cc View 2 chunks +42 lines, -9 lines 0 comments Download
M src/internet/model/udp-l4-protocol.h View 1 7 chunks +38 lines, -8 lines 0 comments Download
M src/internet/model/udp-l4-protocol.cc View 1 10 chunks +231 lines, -22 lines 0 comments Download
M src/internet/model/udp-socket-impl.h View 1 4 chunks +10 lines, -1 line 0 comments Download
M src/internet/model/udp-socket-impl.cc View 1 2 3 4 5 12 chunks +302 lines, -42 lines 2 comments Download
A src/internet/test/ipv6-dual-stack-test-suite.cc View 1 2 3 4 1 chunk +311 lines, -0 lines 0 comments Download
M src/internet/test/tcp-test.cc View 1 7 chunks +113 lines, -10 lines 0 comments Download
M src/internet/test/udp-test.cc View 1 5 chunks +260 lines, -0 lines 0 comments Download
M src/internet/wscript View 1 4 chunks +3 lines, -4 lines 0 comments Download
M src/netanim/examples/star-animation.cc View 1 4 chunks +34 lines, -4 lines 0 comments Download
M src/network/model/socket.h View 1 2 3 4 1 chunk +8 lines, -1 line 0 comments Download
M src/network/utils/ipv6-address.h View 4 chunks +26 lines, -0 lines 0 comments Download
M src/network/utils/ipv6-address.cc View 1 2 chunks +38 lines, -0 lines 0 comments Download
M src/network/utils/packet-socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/network/utils/packet-socket.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/point-to-point-layout/model/point-to-point-dumbbell.h View 1 4 chunks +24 lines, -0 lines 0 comments Download
M src/point-to-point-layout/model/point-to-point-dumbbell.cc View 1 2 3 3 chunks +57 lines, -0 lines 0 comments Download
M src/point-to-point-layout/model/point-to-point-grid.h View 1 4 chunks +31 lines, -0 lines 0 comments Download
M src/point-to-point-layout/model/point-to-point-grid.cc View 1 3 chunks +77 lines, -0 lines 0 comments Download
M src/point-to-point-layout/model/point-to-point-star.h View 1 4 chunks +25 lines, -0 lines 0 comments Download
M src/point-to-point-layout/model/point-to-point-star.cc View 1 3 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 22
Tommaso Pecorella
Wonderful. +1, go ahead with commit (from my side)
10 years, 6 months ago (2011-11-19 11:21:24 UTC) #1
Tommaso Pecorella
Just a reminder, as I've noticed you're not in the cc list for this patch ...
10 years, 6 months ago (2011-11-19 13:09:37 UTC) #2
Vincent Lam
I already build your patch but I get some error. I check it 5 times ...
10 years, 5 months ago (2011-12-03 03:45:40 UTC) #3
Tommaso Pecorella
Hi Vincent, have you checked the following: 1) a good 'ol "waf distclean; waf configure; ...
10 years, 5 months ago (2011-12-03 17:15:13 UTC) #4
Vincent Lam
On 2011/12/03 17:15:13, Tommaso Pecorella wrote: > Hi Vincent, have you checked the following: > ...
10 years, 5 months ago (2011-12-05 04:00:36 UTC) #5
Tommaso Pecorella
Hi, no problem about your English, it's enough to be understood. The main problem can ...
10 years, 5 months ago (2011-12-05 17:16:34 UTC) #6
Vincent Lam
10 years, 5 months ago (2011-12-06 04:23:09 UTC) #7
Vincent Lam
Thank you very much, Mr.Tommaso! I had learn from your experience! I guess this patch ...
10 years, 5 months ago (2011-12-06 04:34:41 UTC) #8
Tommaso Pecorella
Hi Vincent. that one is easy. It's the python bindings. Since they're pre-built, is you ...
10 years, 5 months ago (2011-12-06 09:19:32 UTC) #9
Tommaso Pecorella
H Vincent, actually the command I sent you in the previous mail doesn't work as ...
10 years, 5 months ago (2011-12-06 09:25:25 UTC) #10
Vincent Lam
It works perfectly for me now. Thank you so very much for taking the time ...
10 years, 5 months ago (2011-12-06 12:01:54 UTC) #11
Tommaso Pecorella
Hi Ken, thanks for the update. I got the old mail where Tom was pointing ...
10 years, 4 months ago (2012-01-13 00:09:11 UTC) #12
kdrenard2
> 1) triple check about the patch "clean" apply. Applied cleanly to ns-3-dev as of ...
10 years, 3 months ago (2012-01-30 17:58:04 UTC) #13
Tommaso Pecorella
Beside the comments to the code: 1) about the 5th point (see the previous comment), ...
10 years, 3 months ago (2012-02-02 00:47:03 UTC) #14
kdrenard2
On 2012/02/02 00:47:03, Tommaso Pecorella wrote: > Beside the comments to the code: > > ...
10 years, 3 months ago (2012-02-02 21:58:03 UTC) #15
Tommaso Pecorella
More comments about it will follow. http://codereview.appspot.com/5417048/diff/20001/src/applications/model/udp-echo-client.cc File src/applications/model/udp-echo-client.cc (right): http://codereview.appspot.com/5417048/diff/20001/src/applications/model/udp-echo-client.cc#newcode308 src/applications/model/udp-echo-client.cc:308: NS_LOG_INFO ("Sent " ...
10 years, 3 months ago (2012-02-03 00:36:15 UTC) #16
Tommaso Pecorella
On 2012/02/02 21:58:03, kdrenard2 wrote: > This is up to the developer of the application. ...
10 years, 3 months ago (2012-02-03 00:55:42 UTC) #17
kdrenard2
On 2012/02/03 00:55:42, Tommaso Pecorella wrote: > I sent a comment just before this to ...
10 years, 3 months ago (2012-02-03 13:02:24 UTC) #18
Tom Henderson
I reviewed again; looks ready to merge (early enough in release cycle so we can ...
10 years, 3 months ago (2012-02-09 05:43:38 UTC) #19
Tommaso Pecorella
Found an initialized variable. http://codereview.appspot.com/5417048/diff/48001/src/internet/model/udp-socket-impl.cc File src/internet/model/udp-socket-impl.cc (right): http://codereview.appspot.com/5417048/diff/48001/src/internet/model/udp-socket-impl.cc#newcode69 src/internet/model/udp-socket-impl.cc:69: : m_endPoint (0), Uninitialized variable: ...
10 years, 3 months ago (2012-02-15 16:47:57 UTC) #20
Tommaso Pecorella
http://codereview.appspot.com/5417048/diff/51001/src/internet/model/udp-socket-impl.cc File src/internet/model/udp-socket-impl.cc (right): http://codereview.appspot.com/5417048/diff/51001/src/internet/model/udp-socket-impl.cc#newcode103 src/internet/model/udp-socket-impl.cc:103: } Here is the *#@! memory leak. The function ...
10 years, 3 months ago (2012-02-17 01:06:31 UTC) #21
Tommaso Pecorella
10 years, 3 months ago (2012-02-17 02:15:00 UTC) #22
Sorry for not noticing before :'(

http://codereview.appspot.com/5417048/diff/51001/src/internet/model/udp-socke...
File src/internet/model/udp-socket-impl.cc (right):

http://codereview.appspot.com/5417048/diff/51001/src/internet/model/udp-socke...
src/internet/model/udp-socket-impl.cc:819: UdpSocketImpl::BindToNetDevice
(Ptr<NetDevice> netdevice)
This only works on IPv4. It should work on IPv6 as well (need also an update on
Ipv6EndPoint)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b