Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(973)

Issue 5416047: first cut at runtime skia global settings

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by caryclark1
Modified:
12 years, 5 months ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This allows passing in a string to set runtime global information like the font cache size. I tested this by launching a modified Chromium with: --skia-flags='font-cache-limit=12345678' which passed "font-cache-limit=12345678" to SkGraphics::SetFlags (without quotes). This syntax can be extended to include more name/value pairs, separated by a semicolon. The companion Chromium change might look like: http://codereview.chromium.org/8561023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M include/core/SkGraphics.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/core/SkGraphics.cpp View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 3
caryclark1
just a first cut -- happy to iterate to make more general/useful/safer
12 years, 5 months ago (2011-11-18 19:54:59 UTC) #1
reed1
LGTM
12 years, 5 months ago (2011-11-18 20:05:18 UTC) #2
reed1
12 years, 5 months ago (2011-11-18 20:14:59 UTC) #3
Might add something like 

    --skia-flags='font-cache-limit=12345678'

In the header comment, to show a sample usage (or document that this is highly
volitile, and subject to format changes for now).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b