Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1521)

Issue 5405041: JAVA: Add Maven support for the libphonenumber demo. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by philippe
Modified:
12 years, 4 months ago
Base URL:
https://libphonenumber.googlecode.com/svn/trunk
Visibility:
Public.

Description

JAVA: Add Maven support for the libphonenumber demo. That lets the demo be part of the libphonenumber Maven project thus adds the following benefits: - Automatically update the version of the demo and the libphonenumber artifact the demo depends on when performing a release. - Let Maven handle the deployment of the demo to AppEngine without any need to install the AppEngine SDK. - No need to push the dependency JARs (servlet, apache common fileupload/io) even if they are still here to let you use Ant if you prefer. Note that this CL depends on CL 5395054. Committed: http://code.google.com/p/libphonenumber/source/detail?r=409

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update versions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -4 lines) Patch
A + java/demo/README View 1 chunk +3 lines, -2 lines 0 comments Download
A java/demo/pom.xml View 1 1 chunk +103 lines, -0 lines 0 comments Download
M java/pom.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/java/data/README View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4
philippe
12 years, 5 months ago (2011-11-17 11:40:54 UTC) #1
shaopengjia
http://codereview.appspot.com/5405041/diff/1/java/demo/pom.xml File java/demo/pom.xml (right): http://codereview.appspot.com/5405041/diff/1/java/demo/pom.xml#newcode8 java/demo/pom.xml:8: <version>4.3-SNAPSHOT</version> please update the versions here, and the few ...
12 years, 4 months ago (2011-12-07 14:13:35 UTC) #2
philippe
http://codereview.appspot.com/5405041/diff/1/java/demo/pom.xml File java/demo/pom.xml (right): http://codereview.appspot.com/5405041/diff/1/java/demo/pom.xml#newcode8 java/demo/pom.xml:8: <version>4.3-SNAPSHOT</version> On 2011/12/07 14:13:35, shaopengjia wrote: > please update ...
12 years, 4 months ago (2011-12-08 13:01:38 UTC) #3
Shaopeng
12 years, 4 months ago (2011-12-08 13:06:05 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b