Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1651)

Issue 5401041: Lambaize $ and # in #{ ... #} to make Guile V2 happy. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by dak
Modified:
7 years, 7 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Lambaize $ and # in #{ ... #} to make Guile V2 happy. Unfortunately Guile V2 was not happy about the implementation of closures around #{ ... #} relying on local-eval and procedure-environment. This patch abandons this approach and gets back to a scheme similar like the old one, namely compiling the expressions inside of #{ ... #} in advance. Still, a few advantages over the old approach remain: the expressions are placed into procedures and are evaluated/executed each at the "proper" time rather than when #{ ... #} starts evaluating, so the evaluation order is quite the same as outside of #{ ... #}. Also no artificial temporary variables/name-spaces are created. Currently based off staging, hopefully soon off master.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M lily/include/lily-lexer.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/parse-scm.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M scm/parser-ly-from-scheme.scm View 1 chunk +17 lines, -12 lines 0 comments Download

Messages

Total messages: 1
pkx166h
7 years, 7 months ago (2011-11-17 12:31:20 UTC) #1
passes make and make check - no reg test diffs.

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b